From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C5376B8AE6 for ; Wed, 6 Dec 2023 11:47:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 971C7379BE for ; Wed, 6 Dec 2023 11:47:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Dec 2023 11:47:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AD54E40C73 for ; Wed, 6 Dec 2023 11:47:17 +0100 (CET) References: <20231129132117.217210-1-m.sandoval@proxmox.com> <50f3e171-c2b4-4e59-bd7f-07f81b11c0b7@proxmox.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Maximiliano Sandoval To: Dominik Csapak Cc: Proxmox VE development discussion Date: Wed, 06 Dec 2023 11:21:03 +0100 In-reply-to: <50f3e171-c2b4-4e59-bd7f-07f81b11c0b7@proxmox.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2023 10:47:48 -0000 Dominik Csapak writes: > translating ACME does not make sense to me since it's > the name of the protocol and stands for > Automatic Certificate Management Environment > > i don't think/believe this should be translated > into other languages as a standalone word "ACME" appears in four translatable strings, e.g. msgid "ACME Accounts" Having the term itself being translatable allows the translator to be consistent on which term to use when there are multiple translatable strings containing it. It would be confusing for the user if the only place where they see "ACME" is in the original string. While there are no examples of this specifically for "ACME", there is a similar one: "ACL" is a translatable string which appears in two other translations #: proxmox-widget-toolkit/src/window/AuthEditLDAP.js:361 #: proxmox-widget-toolkit/src/window/SyncWindow.js:110 #: pve-manager/www/manager6/dc/AuthEditLDAP.js:333 #: pve-manager/www/manager6/dc/RealmSyncJob.js:355 #: pve-manager/www/manager6/dc/SyncWindow.js:129 msgid "ACL" msgstr "" There are at least two languages that actually translate it: ru: msgid "ACL" msgstr "=D0=A1=D0=BF=D0=B8=D1=81=D0=BE=D0=BA =D1=83=D0=BF=D1=80=D0=B0= =D0=B2=D0=BB=D0=B5=D0=BD=D0=B8=D1=8F =D0=B4=D0=BE=D1=81=D1=82=D1=83=D0=BF= =D0=BE=D0=BC" ar: msgid "ACL" msgstr "=D9=82=D8=A7=D8=A6=D9=85=D8=A9 =D8=A7=D9=84=D8=AA=D8=AD=D9=83= =D9=85 =D9=81=D9=8A =D8=A7=D9=84=D9=88=D8=B5=D9=88=D9=84" Both translation make use of this in other translations, as shown in the following translations: ru: msgid "Remove ACLs of vanished users and groups." msgstr "=D0=A3=D0=B4=D0=B0=D0=BB=D0=B8=D1=82=D1=8C =D1=81=D0=BF=D0=B8=D1= =81=D0=BA=D0=B8 =D1=83=D0=BF=D1=80=D0=B0=D0=B2=D0=BB=D0=B5=D0=BD=D0=B8=D1= =8F =D0=B4=D0=BE=D1=81=D1=82=D1=83=D0=BF=D0=BE=D0=BC =D0=B8=D1=81=D1=87=D0= =B5=D0=B7=D0=BD=D1=83=D0=B2=D1=88=D0=B8=D1=85 =D0=BF=D0=BE=D0=BB=D1=8C=D0= =B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D0=B5=D0=B9 =D0=B8 =D0=B3=D1=80=D1= =83=D0=BF=D0=BF." ar: msgid "Remove ACLs of vanished users and groups." msgstr "=D8=A5=D8=B2=D8=A7=D9=84=D8=A9 =D9=82=D9=88=D8=A7=D8=A6=D9=85 = =D8=A7=D9=84=D8=AA=D8=AD=D9=83=D9=85 =D8=A8=D8=A7=D9=84=D9=88=D8=B5=D9=88= =D9=84 =D9=84=D9=84=D9=85=D8=B3=D8=AA=D8=AE=D8=AF=D9=85=D9=8A=D9=86 =D9=88= =D8=A7=D9=84=D9=85=D8=AC=D9=85=D9=88=D8=B9=D8=A7=D8=AA =D8=A7=D9=84=D9=85= =D8=AE=D8=AA=D9=81=D9=8A=D8=A9." I personally lean towards not translating it, but in my option, that is a decision that belongs to the translator, having the string be translatable gives them more context to make this choice. All of this would be simpler if we could extract comments with xgettext to signal that certain parts of strings should ideally not be translated. Of course, if this is polemic enough, it could be separated into a different commit/mail-discussion. -- Maximiliano