From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DD5491FF2F6 for ; Wed, 29 May 2024 14:29:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 54D985E4D; Wed, 29 May 2024 14:29:55 +0200 (CEST) From: Maximiliano Sandoval To: Proxmox VE development discussion In-Reply-To: <20240521133148.223266-1-l.wagner@proxmox.com> (Lukas Wagner's message of "Tue, 21 May 2024 15:31:40 +0200") References: <20240521133148.223266-1-l.wagner@proxmox.com> Date: Wed, 29 May 2024 14:29:20 +0200 Message-ID: MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH many v3 0/8] notifications: move template strings to template files X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" ping. Its not possible to build proxmox-perl-rs at the moment without this patch series. Lukas Wagner writes: > These changes adapts the PVE notification stack to the changes introduced > in proxmox-notify 0.4. > > The notification system uses handlebar templates to render the subject > and the body of notifications. Previously, the template strings were > defined inline at the call site. This patch series extracts the templates > into template files and installs them at > /usr/share/pve-manager/templates/default > > where they stored as -{body,subject}.{txt,html}.hbs > > The 'default' part in the path is a preparation for translated > notifications and/or overridable notification templates. > Future work could provide notifications translated to e.g. German > in `templates/de` or similar. This will be a first for having > translated strings on the backend-side, so there is need for further > research. > > Folke kindly did some off-list testing before this was posted, hence > his T-bs were included. > > Bumps/dependencies: > - libproxmox-rs-perl needs to have its proxmox-notify dep updated to 0.4 > and breaks old libpve-notify-perl (versioned break) > - libpve-notify-perl breaks old pve-manager and old pve-ha-manager (versioned break) > > The versioned breaks are necessary due to changed semantics in the API (passing > a template name instead of template strings) and due to changes in how > templates are rendered (separate templates for HTML/plain text, whereas before > both were rendered from the same template string, with some magic from > handlebar helpers) -- Maximiliano _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel