From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 14F121FF0C0 for ; Wed, 21 Oct 2026 11:56:34 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8F6E021611; Wed, 21 Oct 2026 11:56:32 +0200 (CEST) From: Maximiliano Sandoval To: Kefu Chai Subject: Re: [PATCH manager 0/2] ceph: pool: create EC pools from an existing profile In-Reply-To: <20261021054425.3271742-1-k.chai@proxmox.com> (Kefu Chai's message of "Wed, 21 Oct 2026 13:44:23 +0800") References: <20261021054425.3271742-1-k.chai@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 21 Oct 2026 11:56:28 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792576588864 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.767 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: L5L6LJDIC3DNAUNCVKL6N2LAI4LEJTLE X-Message-ID-Hash: L5L6LJDIC3DNAUNCVKL6N2LAI4LEJTLE X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Kefu Chai writes: Comments on each patch. > Hi, > > the docs suggest building a custom erasure code profile with the Ceph > tools and then passing it to 'pveceph pool create' as 'profile'. That > doesn't actually work right now, since the schema still wants 'k' and > 'm': > > # pveceph pool create test-ec --erasure-coding profile=default > 400 Parameter verification failed. > erasure-coding.m: property is missing and it is not optional > erasure-coding.k: property is missing and it is not optional > > Patch 2 makes 'k' and 'm' optional when a profile is given. If they are > passed anyway, they now have to match the profile, where they used to be > ignored. So a script that passed placeholder values next to a profile > would now get an error, which I think is the safer choice, but I'm not > sure everyone agrees. > > Patch 1 needs to go in first. destroypool removes the pool's profile by > default, so once patch 2 makes 'profile=default' easy, destroying such a > pool would take 'default' with it. With patch 1 it only removes the > profile createpool made for that pool, unless asked to. > > Both patches come with tests in a new test/CephPool_test.pl, and I tried > creating and destroying such pools on a three node test cluster. > Feedback welcome, especially on the stricter check in patch 2. The patches look good to me modulo small nits, none of which is a blocker on its own. PS: I did not review the tests. Reviewed-by: Maximiliano Sandoval Tested-by: Maximiliano Sandoval -- Maximiliano