From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 745451FF172
	for <inbox@lore.proxmox.com>; Tue,  1 Apr 2025 15:12:30 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 1C018321C8;
	Tue,  1 Apr 2025 15:12:17 +0200 (CEST)
References: <20250304104954.191259-1-m.sandoval@proxmox.com>
 <D8K5XK48SBUA.2F2K2QARQWH3N@proxmox.com>
User-agent: mu4e 1.10.8; emacs 30.1
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Date: Tue, 01 Apr 2025 15:09:50 +0200
In-reply-to: <D8K5XK48SBUA.2F2K2QARQWH3N@proxmox.com>
Message-ID: <s8oldskt4a9.fsf@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.097 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH installer] gui: always set
 visible-child-name on disk dialog
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>


"Christoph Heiss" <c.heiss@proxmox.com> writes:

> On Tue Mar 4, 2025 at 11:49 AM CET, Maximiliano Sandoval wrote:
>> Whenever a filesystem is selected we show the size selection stack page.
>>
>> At the moment entering any raid setup, then entering the Advanced
>> Options page and then selecting any non-raid setup will show the
>> raiddisk page since it is still the visible child.
>
> While testing this, I cannot seem to reproduce the original problem on
> the latest PVE 8.3-1 ISO.
> In the GUI, clicking on "Options" besides the target harddisk, then in
> the dialog selecting e.g. "zfs (RAID1)", going to the "Advanced Options"
> tab and then selecting e.g. "ext4" above, yields the normal disk sizing
> options tab as expected.


You are right, I just noticed that not all raid setups reproduce this
issue. Selecting the advanced options in "btrfs (RAID10)" and going back
to ext4, for example, reproduces the issue.

> On the main disk selection page, the dropdown is also updated
> accordingly.
>
> Or is some other combination of inputs required to trigger this bug?
> This is just based upon the patch description.

The commit message should be updated, I will do that if there is a need
for v2.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel