From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 66297B8D3B for ; Wed, 6 Dec 2023 15:15:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F3FF2E77 for ; Wed, 6 Dec 2023 15:15:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Dec 2023 15:15:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 921464034D for ; Wed, 6 Dec 2023 15:15:32 +0100 (CET) References: <20231129132117.217210-1-m.sandoval@proxmox.com> <50f3e171-c2b4-4e59-bd7f-07f81b11c0b7@proxmox.com> <97caa32b-eb4d-434e-965c-b65d51761a41@proxmox.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Maximiliano Sandoval To: Dominik Csapak Cc: Proxmox VE development discussion Date: Wed, 06 Dec 2023 15:04:42 +0100 In-reply-to: <97caa32b-eb4d-434e-965c-b65d51761a41@proxmox.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2023 14:15:33 -0000 Dominik Csapak writes: > it's more like DHCP, SLAAC or IPv4. those are names of protocols (like AC= ME) > that shouldn't change across translations > > and we removed those gettexts (mostly) a while ago > e.g. see lxc/Network.js in pve-manager: > > ---8<--- > boxLabel: 'DHCP', // do not localize > --->8--- Do note the following examples: #: pve-manager/www/manager6/qemu/IPConfigEdit.js:97 #: pve-manager/www/manager6/qemu/IPConfigEdit.js:155 msgid "DHCP" msgstr "=D8=A8=D8=B1=D9=88=D8=AA=D9=88=D9=83=D9=88=D9=84 =D8=A7=D9=84= =D8=AA=D9=87=D9=8A=D8=A6=D8=A9 =D8=A7=D9=84=D8=A2=D9=84=D9=8A=D8=A9 =D9=84= =D9=84=D9=85=D8=B6=D9=8A=D9=81=D9=8A=D9=86 (DHCP)" #: pve-manager/www/manager6/qemu/IPConfigEdit.js:163 msgid "SLAAC" msgstr "Autoconfiguration SLAAC" #: pve-manager/www/manager6/ceph/CephInstallWizard.js:476 msgid "First Ceph monitor" msgstr "=D8=A3=D9=88=D9=84 =D8=AC=D9=87=D8=A7=D8=B2 =D9=85=D8=B1=D8=A7= =D9=82=D8=A8=D8=A9" What would be the purpose of removing the translation of the words themselves if they are already being translated elsewhere. -- Maximiliano