From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AE7E41FF137 for ; Tue, 17 Mar 2026 13:59:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 20C8ED989; Tue, 17 Mar 2026 13:59:28 +0100 (CET) From: Maximiliano Sandoval To: Arthur Bied-Charreton Subject: Re: [pve-devel] [PATCH pve-cluster v2 1/3] fix #6701: Add keyUsage extension to root CA In-Reply-To: <20260126100534.86882-5-a.bied-charreton@proxmox.com> (Arthur Bied-Charreton's message of "Mon, 26 Jan 2026 10:55:44 +0100") References: <20260126100534.86882-3-a.bied-charreton@proxmox.com> <20260126100534.86882-5-a.bied-charreton@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Tue, 17 Mar 2026 13:58:33 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773752272530 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.944 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DXCHQGX4N2XEM56BKW4WYYQP745L47DJ X-Message-ID-Hash: DXCHQGX4N2XEM56BKW4WYYQP745L47DJ X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Arthur Bied-Charreton writes: > Add the keyUsage[1] extension to the PVE root CA to comply with RFC > 5280, which Python decided to enforce as of 3.13 by adding the > VERIFY_X509_STRICT flag, which breaks some clients like Ansible. If there is a v2, it would be good to mention that this flag (ssl.VERIFY_X509_STRICT) comes from python's [ssl] module. And that the change of behavior in 3.13 is documented at [create_default_context]. [ssl] https://docs.python.org/3/library/ssl.html [create_default_context] https://docs.python.org/3/library/ssl.html#ssl.create_default_context > > The authorityKeyIdentifier[2] and subjectKeyIdentifier[3] extensions are > required by RFC 5280 as well, however OpenSSL adds them in by default > based on /etc/ssl/openssl.cnf, so there is no need for explicitly > passing them. > > Test script: > ``` > import socket, ssl > > ctx = ssl.create_default_context(cafile="/etc/pve/pve-root-ca.pem") > ctx.wrap_socket(socket.create_connection(("localhost", 8006)), > server_hostname="localhost") > print("success") > ``` > > [1] https://www.rfc-editor.org/rfc/rfc5280#section-4.2.1.3 > [2] https://www.rfc-editor.org/rfc/rfc5280#section-4.2.1.1 > [3] https://www.rfc-editor.org/rfc/rfc5280#section-4.2.1.2 > > Suggested-by: Stoiko Ivanov > Signed-off-by: Arthur Bied-Charreton > --- > src/PVE/Cluster/Setup.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/PVE/Cluster/Setup.pm b/src/PVE/Cluster/Setup.pm > index 75d3507..4f528ba 100644 > --- a/src/PVE/Cluster/Setup.pm > +++ b/src/PVE/Cluster/Setup.pm > @@ -439,6 +439,8 @@ sub gen_pveca_cert { > '-new', > '-x509', > '-nodes', > + '-addext', > + 'keyUsage=critical,keyCertSign,cRLSign', > '-key', > $pveca_key_fn, > '-out', -- Maximiliano