From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B6F581FF183 for ; Wed, 17 Dec 2025 15:04:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7BACF4A18; Wed, 17 Dec 2025 15:05:32 +0100 (CET) From: Maximiliano Sandoval To: Fiona Ebner In-Reply-To: <20251217131724.118681-1-f.ebner@proxmox.com> (Fiona Ebner's message of "Wed, 17 Dec 2025 14:17:09 +0100") References: <20251217131724.118681-1-f.ebner@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 17 Dec 2025 15:05:29 +0100 Message-ID: MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765980319560 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.093 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH-SERIES common/qemu-server 0/3] fix #7092: systemd: vmid.scope: add orderings to fix dbus-vmstate cleanup (regression) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Fiona Ebner writes: > Fixes bug #7092 as well as a regression [0] in combination with HA > shutdown policy 'migrate' caused by commit 1f2c5146 ("migrate: remove > left-over dbus-vmstate instance when migrating without conntrack > state"). Currently, the HA migrations do not migrate the conntrack > state and before this patch, the dbus.service is stopped too early > during shutdown, before the LRM migrations. This led to failure when > trying to check for a left-over dbus-vmstate instance, because > the Net::DBus->system() call would fail. > > It is not enough to record the After=dbus.service dependency, because > systemd would already stop the vmid.scope even while processes in it > are still running. Add a Before=pve-ha-lrm.service and for consistency > Before=pve-guests.service to record the ordering on shutdown. This > ensures that the scope units are still around until the LRM or guests > service had the chance to stop, and usually, handle the remaining > running guests itself. > > Also guard more errors in qemu_del_dbus_vmstate(). > > Many thanks to Maximiliano and Fabian for discussing the issue and > solutions! > > [0]: https://forum.proxmox.com/threads/169739/post-825256 > > > Dependency bump qemu-server -> libpve-common-perl needed! Thanks for working on this! This series fixes the issue described at 7092 and the forum thread. My testing setup is: - Create a 2 node cluster - Set shutdown policy to migrate - Create VM on node 1 - Start the VM - Add the VM to the HA resources - Run `$ shutdown now` from node 1 and with this patch the migration succeeds without warnings and the node is able to properly shut down. Tested-by: Maximiliano Sandoval -- Maximiliano _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel