From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <m.sandoval@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id B0E13BA656
for <pve-devel@lists.proxmox.com>; Thu, 14 Dec 2023 11:51:01 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 8E6CC15AAF
for <pve-devel@lists.proxmox.com>; Thu, 14 Dec 2023 11:50:31 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Thu, 14 Dec 2023 11:50:30 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B7FFE4759C
for <pve-devel@lists.proxmox.com>; Thu, 14 Dec 2023 11:50:30 +0100 (CET)
References: <20231123160902.282661-1-l.wagner@proxmox.com>
User-agent: mu4e 1.10.8; emacs 29.1
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Lukas
Wagner <l.wagner@proxmox.com>
Date: Thu, 14 Dec 2023 11:26:44 +0100
In-reply-to: <20231123160902.282661-1-l.wagner@proxmox.com>
Message-ID: <s8o7clhys5m.fsf@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.002 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH manager 1/2] ui: dc: backup: improve UX for
the different 'notification-mode's
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 14 Dec 2023 10:51:01 -0000
Lukas Wagner <l.wagner@proxmox.com> writes:
> - Switch order of 'mailto' and 'mailnotification' field
> - When mode is 'auto', disable 'mailtnotification' field
> - When mode is 'auto' and 'mailto' is empty, show
> hint that the notification system will be used
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Tested both commits, they do what they promise.
> + let notificationSystemHint = Ext.create({
> + xtype: 'displayfield',
> + padding: '0 0 0 5',
> + userCls: 'pmx-hint',
> + hidden: true,
> + value: gettext('No email configured, the notification system will be used'),
> + viewModel,
> + bind: {
> + hidden: '{!hintTextVisible}',
I think the `pmx-hint` being displayed as yellow suggests it is a
warning/error rather than a hint. I wonder if there is a better
approach, as this is certainly not a warning.
Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
--
Maximiliano