From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EB53A1FF189 for <inbox@lore.proxmox.com>; Fri, 21 Mar 2025 14:11:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 691DC1DE29; Fri, 21 Mar 2025 14:11:18 +0100 (CET) References: <20250124143709.374750-1-m.sandoval@proxmox.com> <20250124143709.374750-2-m.sandoval@proxmox.com> <202fcecb-7ee4-4f63-aede-3d00e7352ee9@proxmox.com> User-agent: mu4e 1.10.8; emacs 30.1 From: Maximiliano Sandoval <m.sandoval@proxmox.com> To: Thomas Lamprecht <t.lamprecht@proxmox.com> Date: Fri, 21 Mar 2025 13:47:35 +0100 In-reply-to: <202fcecb-7ee4-4f63-aede-3d00e7352ee9@proxmox.com> Message-ID: <s8o4izmfs0d.fsf@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.099 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH proxmox-i18n v2 2/2] make: add proxmox-datacenter-manager translations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Thomas Lamprecht <t.lamprecht@proxmox.com> writes: > btw. instead of pinging a series unconditionally a better approach might > be to use that as an opportunity to self-test the whole series, i.e. apply > them locally and see if all works out; that would have made most issues of > this series visible. > If that succeeded, then asking someone directly for an end-to-end test > and/or review before sending the second ping or so out would also be more > productive IMO, as a tested-by gives maintainers at least some basic > assurance that the whole thing works in principle... > this fails with errors like > > proxmox-yew-comp.pot:185: duplicate message definition... > proxmox-widget-toolkit.pot:2081: ...this is the location of the first definition > > Which is a result from the former file having this combined: > > msgid "Warning" > msgid_plural "Warnings" > msgstr[0] "" > msgstr[1] "" > > While the latter has it split: > > msgid "Warning" > msgstr "" > > msgid "Warnings" > msgstr "" > > There are others if this is fixed. I see no reference to other patches or steps > we need to apply/take before this series, so what's the idea here? The requirements are: - https://lore.proxmox.com/pdm-devel/20250122150132.426276-1-m.sandoval@proxmox.com/ - https://lore.proxmox.com/yew-devel/20250127094651.139204-1-m.sandoval@proxmox.com/ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel