From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 997011FF138 for ; Wed, 18 Feb 2026 12:21:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 11F0A1B0B5; Wed, 18 Feb 2026 12:22:11 +0100 (CET) From: Maximiliano Sandoval To: Dominik Rusovac Subject: Re: [PATCH yew-mobile-gui 3/3] dashboard: polish CPU utilization presentation In-Reply-To: <20260218110333.158265-4-d.rusovac@proxmox.com> (Dominik Rusovac's message of "Wed, 18 Feb 2026 12:03:33 +0100") References: <20260218110333.158265-1-d.rusovac@proxmox.com> <20260218110333.158265-4-d.rusovac@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 18 Feb 2026 12:21:35 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771413688094 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.086 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: R6ZU7EJS3P6CXJ7JS5SJJFMP73AT5IWK X-Message-ID-Hash: R6ZU7EJS3P6CXJ7JS5SJJFMP73AT5IWK X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Dominik Rusovac writes: > To align with the CPU utilization presentation in the web ui, this adds > "CPU(s)" as the unit of the total number of CPUs displayed above to the > right of the CPU utilization bar. > > Signed-off-by: Dominik Rusovac > --- > src/pages/page_dashboard.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/pages/page_dashboard.rs b/src/pages/page_dashboard.rs > index 93e0f83..9bd6141 100644 > --- a/src/pages/page_dashboard.rs > +++ b/src/pages/page_dashboard.rs > @@ -122,7 +122,7 @@ impl PvePageDashboard { > tiles.push( > icon_list_tile(Fa::new("cpu"), tr!("CPU"), (), ()).with_child(list_tile_usage( > format!("{cpu_percentage:.2}%"), > - maxcpu.to_string(), > + format!("{maxcpu} CPU(s)"), This should be translatable, see e.g. https://lore.proxmox.com/all/20260128085614.91769-2-m.sandoval@proxmox.com/. > cpu as f32, > )), > ); -- Maximiliano