From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8D3511FF13F for ; Thu, 26 Mar 2026 12:45:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 612E710012; Thu, 26 Mar 2026 12:45:33 +0100 (CET) From: Maximiliano Sandoval To: Kefu Chai Subject: Re: [PATCH manager] ceph: init: drop deprecated pg_bits parameter In-Reply-To: <20260325043120.2289935-1-k.chai@proxmox.com> (Kefu Chai's message of "Wed, 25 Mar 2026 12:31:20 +0800") References: <20260325043120.2289935-1-k.chai@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Thu, 26 Mar 2026 12:45:28 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774525480492 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.125 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QQUR3HI4AZEQLKFAO3QJL6QB6U4HZDT4 X-Message-ID-Hash: QQUR3HI4AZEQLKFAO3QJL6QB6U4HZDT4 X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Kefu Chai writes: > The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the > underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed > from Ceph in v13.0.2. The implementation was made a no-op at that point, > with a TODO to remove the parameter declaration in PVE 9. > > We are now at pve-manager 9.1.6. The minimum Ceph version supported by > pveceph init is Nautilus (v14), which is already past the point where > these options existed, so the parameter has been a guaranteed no-op on > every cluster PVE 9 can manage. Remove it along with the adjacent > dead-code comments. > > Signed-off-by: Kefu Chai Since the parameter is only used during ceph initialization, this looks OK to me. Reviewed-by: Maximiliano Sandoval -- Maximiliano