From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AB62B1FF141 for ; Tue, 30 Jun 2026 08:41:29 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 746A721419; Tue, 30 Jun 2026 08:41:28 +0200 (CEST) From: Maximiliano Sandoval To: Fiona Ebner Subject: Re: [PATCH qemu-server 2/2] vm start: log qemu version when starting a VM In-Reply-To: <1e8aeca4-ca85-428f-98c0-ea4e2a49af05@proxmox.com> (Fiona Ebner's message of "Mon, 29 Jun 2026 16:12:12 +0200") References: <20260624084201.168436-1-m.sandoval@proxmox.com> <20260624084201.168436-2-m.sandoval@proxmox.com> <1e8aeca4-ca85-428f-98c0-ea4e2a49af05@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Tue, 30 Jun 2026 08:41:22 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782801671163 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NJEEWXX2AOK3ZOU2JVULUM47LOBVFQ6H X-Message-ID-Hash: NJEEWXX2AOK3ZOU2JVULUM47LOBVFQ6H X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fiona Ebner writes: > Am 24.06.26 um 10:42 AM schrieb Maximiliano Sandoval: >> Previously, having the system journal and task logs from a boot was not >> enough to determine which qemu version is installed nor the running QEMU >> version of a VM. This is addressed by logging pve-qemu-kvm's package >> version when starting the VM. >> >> The package version is obtained with the 'query-version' qmp command. >> >> Signed-off-by: Maximiliano Sandoval >> --- >> >> Notes: >> sample output in the journal: >> >> Jun 24 10:39:14 pve-148 qm[26137]: VM 100 started with PID 26166 using pve-qemu-kvm_11.0.0-4. >> >> src/PVE/QemuServer.pm | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm >> index 55e9f520..d6576a41 100644 >> --- a/src/PVE/QemuServer.pm >> +++ b/src/PVE/QemuServer.pm >> @@ -5839,7 +5839,8 @@ sub vm_start_nolock { >> eval { PVE::QemuServer::PCI::reserve_pci_usage($pci_reserve_list, $vmid, undef, $pid) }; >> warn $@ if $@; >> >> - syslog("info", "VM $vmid started with PID $pid."); >> + my $pgk_version = get_package_version($vmid); > > Typo: pgk > >> + syslog("info", "VM $vmid started with PID $pid using $pgk_version."); >> >> PVE::QemuServer::RunState::create_cleanup_flag($vmid); >> >> @@ -8054,6 +8055,12 @@ sub get_running_qemu_version { >> return "$res->{qemu}->{major}.$res->{qemu}->{minor}"; >> } >> >> +sub get_package_version { > > This should live in QMPHelpers.pm. Then it's automatically clear that it > is queried via QMP when you're reading the code of a call site. Also, > maybe get_qemu_package_version() to be even more explicit. > It is there because get_running_qemu_version is above. >> + my ($vmid) = @_; >> + my $res = mon_cmd($vmid, "query-version"); >> + return $res->{package}; >> +} >> + >> sub qemu_use_old_bios_files { >> my ($machine_type) = @_; >> -- Maximiliano