From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 366A81FF16B for ; Thu, 31 Oct 2024 10:53:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B245236694; Thu, 31 Oct 2024 10:53:42 +0100 (CET) Date: Thu, 31 Oct 2024 10:53:08 +0100 From: Christoph Heiss To: Aaron Lauterer Message-ID: References: <20241022101941.329529-1-c.heiss@proxmox.com> <20241022101941.329529-3-c.heiss@proxmox.com> <9ddd8807-5623-484f-aa5d-b751d732ae53@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9ddd8807-5623-484f-aa5d-b751d732ae53@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs 2/3] pci-passthrough: mention that `intel_iommu=on` is the default for 6.8+ X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thanks for taking a look! On Tue, Oct 29, 2024 at 02:17:59PM GMT, Aaron Lauterer wrote: > Looking at the surrounding context, I would rework this section even more. > Before I just apply my approach, what do you think about the following > change? > --- > diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc > index 4f19f2a..ca07692 100644 > --- a/qm-pci-passthrough.adoc > +++ b/qm-pci-passthrough.adoc > @@ -63,19 +63,18 @@ some configuration to enable PCI(e) passthrough. > > .IOMMU > > -First, you will have to enable IOMMU support in your BIOS/UEFI. Usually the > +You will have to enable IOMMU support in your BIOS/UEFI. Usually the > corresponding setting is called `IOMMU` or `VT-d`, but you should find the > exact > option name in the manual of your motherboard. > > -For Intel CPUs, you also need to enable the IOMMU on the > -xref:sysboot_edit_kernel_cmdline[kernel command line] kernels by adding: > +With recent kernels (6.8 or newer), `IOMMU` should be enabled I'd drop the code tags for IOMMU here (and add a "the") -- like in the first sentence -- since this is referring to the IOMMU in a more general sense rather than a specific setting as above such, IMO. > automatically. Since you drop the note about AMD CPUs below, I'd either keep that one below or explicitly mention here that this automatic enablement is for both Intel and AMD CPUs. Otherwise users/admin might be left wondering what needs to be done for AMD CPUs, if only Intel are mentioned here. Just to be thorough. > +On older kernels, it was necessary to enable it on Intel CPUs via the > +xref:sysboot_edit_kernel_cmdline[kernel command line] by adding: > > ---- > intel_iommu=on > ---- > > -For AMD CPUs it should be enabled automatically. > - > .IOMMU Passthrough Mode > > If your hardware supports IOMMU passthrough mode, enabling this mode might > [..] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel