From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CC5319D8B4 for ; Fri, 27 Oct 2023 13:06:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A681F3844F for ; Fri, 27 Oct 2023 13:06:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 27 Oct 2023 13:06:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CAD0E424F7 for ; Fri, 27 Oct 2023 13:06:13 +0200 (CEST) Date: Fri, 27 Oct 2023 13:06:12 +0200 From: Christoph Heiss To: Aaron Lauterer Cc: Proxmox VE development discussion Message-ID: References: <20231025160011.3617524-1-a.lauterer@proxmox.com> <20231025160011.3617524-13-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025160011.3617524-13-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.rs, proxmox.com] Subject: Re: [pve-devel] [PATCH 12/12] tui: remove unused read_json function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2023 11:06:44 -0000 Could be squased into the previous patch IMO if you do send a v2, but not a blocker either for me if not. In any case: Reviewed-by: Christoph Heiss On Wed, Oct 25, 2023 at 06:00:11PM +0200, Aaron Lauterer wrote: > > Signed-off-by: Aaron Lauterer > --- > proxmox-tui-installer/src/setup.rs | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/proxmox-tui-installer/src/setup.rs b/proxmox-tui-installer/src/setup.rs > index 211a96b..efcabed 100644 > --- a/proxmox-tui-installer/src/setup.rs > +++ b/proxmox-tui-installer/src/setup.rs > @@ -1,13 +1,10 @@ > use std::{ > collections::HashMap, > fmt, > - fs::File, > - io::BufReader, > net::IpAddr, > - path::Path, > }; > > -use serde::{Deserialize, Serialize, Serializer}; > +use serde::{Serialize, Serializer}; > > use crate::options::InstallerOptions; > use proxmox_installer_common::{ > @@ -129,13 +126,6 @@ impl From for InstallConfig { > } > } > > -pub fn read_json Deserialize<'de>, P: AsRef>(path: P) -> Result { > - let file = File::open(path).map_err(|err| err.to_string())?; > - let reader = BufReader::new(file); > - > - serde_json::from_reader(reader).map_err(|err| format!("failed to parse JSON: {err}")) > -} > - > fn serialize_disk_opt(value: &Option, serializer: S) -> Result > where > S: Serializer, > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >