From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3C70E1FF141 for ; Mon, 30 Mar 2026 14:04:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F49B1EA3F; Mon, 30 Mar 2026 14:05:16 +0200 (CEST) Date: Mon, 30 Mar 2026 14:04:42 +0200 From: Gabriel Goller To: Thomas Lamprecht Subject: Re: [PATCH pve-manager v8 21/21] sdn: add dry-run diff view for sdn apply Message-ID: Mail-Followup-To: Thomas Lamprecht , pve-devel@lists.proxmox.com, Wolfgang Bumiller References: <20260327150127.545193-1-g.goller@proxmox.com> <20260327150127.545193-22-g.goller@proxmox.com> <69536c3b-c7dc-4409-981d-783949dc5d03@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <69536c3b-c7dc-4409-981d-783949dc5d03@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774872228438 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.477 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2MZVD6HTLZFA7ZZT4IEKQJ3TEVCFLX44 X-Message-ID-Hash: 2MZVD6HTLZFA7ZZT4IEKQJ3TEVCFLX44 X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com, Wolfgang Bumiller X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 28.03.2026 21:19, Thomas Lamprecht wrote: > Am 27.03.26 um 16:01 schrieb Gabriel Goller: > > Introduce a new SdnDiffView modal that runs a dry-run and shows the frr > > and ifupdown2 configuration changes which will be made when clicking > > apply. Now the user knows which config options will be set without > > needing to apply the config. > > This is not really a ideal (modern) ExtJS component implementation, i.e. > could be more declarative, and has some smaller UX issues, like scrolling > the whole view, not the two panels that can actually get taller separately. > > We also might want to load this for all nodes, as with more than a handful > of nodes this becomes rather very annoying to cross-check. But that we > can still do/extend later just fine, so no hard feelings here for now. Yep agree, especially when creating per-node components such as the bgp controller this could be useful. > My reimplementation that's still relatively close to yours semantically: > > Ext.define('PVE.sdn.SdnDiffView', { > extend: 'Ext.window.Window', > > width: 800, > height: 900, > [snip] I'll test your component and send it as a patch tommorow. Then we'll have a look at a multi-node view in the future. Thanks!