From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1C4F0F9E1 for ; Mon, 24 Jul 2023 11:57:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0611EC6CE for ; Mon, 24 Jul 2023 11:57:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 24 Jul 2023 11:56:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AD30443AA2 for ; Mon, 24 Jul 2023 11:56:59 +0200 (CEST) Date: Mon, 24 Jul 2023 11:56:59 +0200 From: Wolfgang Bumiller To: Lukas Wagner Cc: pve-devel@lists.proxmox.com Message-ID: References: <20230720143236.652292-1-l.wagner@proxmox.com> <20230720143236.652292-41-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720143236.652292-41-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.133 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH v4 pve-common 40/69] JSONSchema: increase maxLength of config-digest to 64 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2023 09:57:01 -0000 applied, thanks On Thu, Jul 20, 2023 at 04:32:07PM +0200, Lukas Wagner wrote: > The new notification backend is implemented in Rust where we use SHA256 > for config digests. > > Signed-off-by: Lukas Wagner > --- > src/PVE/JSONSchema.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm > index 7589bba..49e0d7a 100644 > --- a/src/PVE/JSONSchema.pm > +++ b/src/PVE/JSONSchema.pm > @@ -93,10 +93,13 @@ register_standard_option('pve-bridge-id', { > }); > > register_standard_option('pve-config-digest', { > - description => 'Prevent changes if current configuration file has different SHA1 digest. This can be used to prevent concurrent modifications.', > + description => 'Prevent changes if current configuration file has a different digest. ' > + . 'This can be used to prevent concurrent modifications.', > type => 'string', > optional => 1, > - maxLength => 40, # sha1 hex digest length is 40 > + # sha1 hex digests are 40 characters long > + # sha256 hex digests are 64 characters long (sha256 is used in our Rust code) > + maxLength => 64, > }); > > register_standard_option('skiplock', { > -- > 2.39.2