From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CDD2EBABD8 for ; Fri, 15 Dec 2023 13:08:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B19911EA1 for ; Fri, 15 Dec 2023 13:08:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 15 Dec 2023 13:08:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 09E99479C6 for ; Fri, 15 Dec 2023 13:08:23 +0100 (CET) Date: Fri, 15 Dec 2023 13:08:22 +0100 From: Christoph Heiss To: Maximiliano Sandoval Cc: pve-devel@lists.proxmox.com Message-ID: References: <20231121151025.233224-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121151025.233224-1-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2023 12:08:24 -0000 LGTM. Tested this using latest master + ISO base. Keyboard shortcuts also work as before. Please consider it: Tested-by: Christoph Heiss Reviewed-by: Christoph Heiss On Tue, Nov 21, 2023 at 04:10:18PM +0100, Maximiliano Sandoval wrote: > > We replace the use of nested boxes with grids when possible to ensure correct > margins and alignment of widgets. > > At the end we also remove trailing spaces and colons from labels preceding an > input widget, e.g. we replace `DNS Server: ` with `DNS Server`. > > Differences from v1: > - Rebased on top of master > > Maximiliano Sandoval (7): > gui: move create_basic_grid subroutine definition up > gui: expand ip address Gtk3::Entry > gui: use basic grid in password panel > gui: use basic grid in country/timezone panel > gui: change margins in create_basic_grid > gui: use basic grid in the network panel > gui: remove trailing spaces and colons > > proxinstall | 153 +++++++++++++++++++++++----------------------------- > 1 file changed, 66 insertions(+), 87 deletions(-) > > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >