From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 3C5EC1FF185
	for <inbox@lore.proxmox.com>; Mon,  7 Jul 2025 19:22:18 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 2A43F80C9;
	Mon,  7 Jul 2025 19:23:02 +0200 (CEST)
Date: Mon, 7 Jul 2025 19:22:28 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Message-ID: <qopxbsprfkgypqsu4wf6codlrxewjml2mrugpmktnii2bilsdb@6q72wh5hxlpk>
Mail-Followup-To: Wolfgang Bumiller <w.bumiller@proxmox.com>, 
 pve-devel@lists.proxmox.com
References: <20250702145101.894299-1-g.goller@proxmox.com>
 <20250702145101.894299-18-g.goller@proxmox.com>
 <ep5a2ps2swhztxzunmluie4litjmhq34svpfquewwgpzw3jm3o@l4j6iij3cth7>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <ep5a2ps2swhztxzunmluie4litjmhq34svpfquewwgpzw3jm3o@l4j6iij3cth7>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.014 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH proxmox-ve-rs v4 11/22] config: sdn:
 fabrics: add node section types
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: pve-devel@lists.proxmox.com
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 07.07.2025 14:19, Wolfgang Bumiller wrote:
>On Wed, Jul 02, 2025 at 04:50:02PM +0200, Gabriel Goller wrote:
>> [snip]
>> +impl std::fmt::Display for NodeSectionId {
>> +    fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
>> +        write!(f, "{}_{}", self.fabric_id.as_ref(), self.node_id)
>
>^ The .as_ref() could be dropped - or also added to node_id... but they
>both implement `Display` by forwarding anyway.

Removed the .as_ref().

>> +    }
>> +}
>> +

Thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel