From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ABF3893A5A for ; Tue, 6 Feb 2024 14:25:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8C1D0343F9 for ; Tue, 6 Feb 2024 14:25:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 6 Feb 2024 14:25:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B21A5447E2 for ; Tue, 6 Feb 2024 14:25:04 +0100 (CET) Date: Tue, 6 Feb 2024 14:25:04 +0100 From: Christoph Heiss To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: References: <20231130100147.233793-1-c.heiss@proxmox.com> <6ecd03ab-1420-4766-9505-c3a6cae5cf87@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ecd03ab-1420-4766-9505-c3a6cae5cf87@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer 0/2] expose zfs arc size setting for all products X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2024 13:25:05 -0000 On Tue, Feb 06, 2024 at 01:49:36PM +0100, Thomas Lamprecht wrote: > Am 30/11/2023 um 11:01 schrieb Christoph Heiss: > > As suggested by Thomas, sets the default to 50% for all non-PVE > > products. > > > > Quickly smoke-tested this, to see if all installer show the correct > > value in the GUI/TUI. > > What I'm wondering if we should skip actively setting this as module > parameter if the user did not changed the value at all? Sounds like a pretty reasonable "default" actually, just keeping the ZFS defaults. So I'd be happy to implement that. > > That way it would stay dynamic, e.g., if one increased the memory of > a PBS or PMG instance, but one could also interpret that as bad thing, > especially if the MiB number was shown. Should this behaviour only apply to the PBS/PMG installer then? Or to PVE as well? > For GTK we could just go for a placeholder text showing the number, > but there isn't really such a UX-mechanic available for the TUI one > AFAICT. Yeah, we'd need to implement placeholders for the TUI ourselves. Shouldn't be too hard tho, I got a rough idea mind how it be fitted in there. > > Anyhow, I can be OK with always hard-coding, just wanted to know > your (or others) thoughts on this.