From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1A855CB11 for ; Mon, 10 Jul 2023 11:48:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04F843D3D0 for ; Mon, 10 Jul 2023 11:48:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 10 Jul 2023 11:48:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 97A5542583 for ; Mon, 10 Jul 2023 11:48:45 +0200 (CEST) Date: Mon, 10 Jul 2023 11:48:44 +0200 From: Christoph Heiss To: Proxmox VE development discussion , Noel Ullreich Message-ID: References: <20230710092227.24642-1-n.ullreich@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710092227.24642-1-n.ullreich@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve_installer v3] tui: don't abort install if min ram requirement is not met X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2023 09:48:47 -0000 LGTM. On Mon, Jul 10, 2023 at 11:22:27AM +0200, Noel Ullreich wrote: > If the minimum requirements are not met, the TUI installer will create a > popup notifying you that the install might not work and then exits the > installer. > While the GUI also creates such a popup, it will not exit the installer. > This patch adapts the behavior of the GUI: the TUI creates a popup > warning you that min spec is not met but doesn't abort the install. > Reviewed-by: Christoph Heiss Tested-by: Christoph Heiss > Signed-off-by: Noel Ullreich > --- > changes from v1: > * moved the min ram check into `installer_setup_late` > * fixed spelling in the subject line > > changes from v2: > * fixed formatting > * removed unnecessary `installer_setup_late` call > > proxmox-tui-installer/src/main.rs | 13 +++++++++++-- > proxmox-tui-installer/src/system.rs | 14 +------------- > 2 files changed, 12 insertions(+), 15 deletions(-) > > [..]