From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 099581FF17C
	for <inbox@lore.proxmox.com>; Wed,  2 Apr 2025 10:43:57 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 1F03AC823;
	Wed,  2 Apr 2025 10:43:45 +0200 (CEST)
Date: Wed, 2 Apr 2025 10:43:11 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>, 
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 pve-devel <pve-devel-bounces@lists.proxmox.com>
Message-ID: <q52bo3n7xnf4dey7nac6huyne6u22inmyjzdgzob2c5i43jsr3@4ye5bsitzstn>
Mail-Followup-To: Shannon Sterz <s.sterz@proxmox.com>, 
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 pve-devel <pve-devel-bounces@lists.proxmox.com>
References: <20250328171340.885413-1-g.goller@proxmox.com>
 <20250328171340.885413-53-g.goller@proxmox.com>
 <D8UBHZP29Y1F.3P978YHUL3Q1E@proxmox.com>
 <mray7o47uv6ndfud5fzsp6rhcvctwdjhwx5tfxul74kmargi7p@3ummcuvb37ab>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <mray7o47uv6ndfud5fzsp6rhcvctwdjhwx5tfxul74kmargi7p@3ummcuvb37ab>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.024 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-docs 1/1] fabrics: add initial
 documentation for sdn fabrics
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

>>>[snip]
>>>+Name:: This is the name of the OpenFabric fabric and can be at most 8 characters long.
>>>+
>>>+Loopback Prefix:: CIDR (IPv4 or IPv6) network range (e.g., 10.0.0.0/24) used to verify that
>>>+all router-IDs in the fabric are contained within this prefix.
>>>+
>>>+Hello Interval:: Controls how frequently (in seconds) hello packets are sent to
>>>+discover and maintain connections with neighboring nodes. Lower values detect
>>>+failures faster but increase network traffic. If empty, the default value will
>>
>>what is the default value? would it make sense to mention that here?
>
>I decided against using default values as I wanted FRR to handle them.
>We also don't set default-options in the FRR config, but just delete the
>property and let FRR handle it.
>
>Maybe I could write the: "the default FRR value will be used"?

I changed my mind, I'll include the default value :)
FRR also doesn't show it in the docs (for openfabric at least) and I
guess it's quite useful for developers to see if they need/want to set
it manually.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel