From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4AF4DFBF8 for ; Mon, 24 Jul 2023 15:31:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E1E0F530 for ; Mon, 24 Jul 2023 15:30:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 24 Jul 2023 15:30:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 665A0425E9 for ; Mon, 24 Jul 2023 15:30:30 +0200 (CEST) Date: Mon, 24 Jul 2023 15:30:29 +0200 From: Wolfgang Bumiller To: Lukas Wagner Cc: pve-devel@lists.proxmox.com Message-ID: References: <20230720143236.652292-1-l.wagner@proxmox.com> <20230720143236.652292-40-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720143236.652292-40-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.117 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] partially-applied: [PATCH v4 pve-guest-common 39/69] vzdump: add config options for new notification backend X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2023 13:31:01 -0000 applied the guest-common part, thanks On Thu, Jul 20, 2023 at 04:32:06PM +0200, Lukas Wagner wrote: > - Add new option 'notification-target' > Allows to select to which endpoint/group notifications shall be sent > - Add new option 'notification-policy' > Replacement for the now deprecated 'mailnotification' option. Mostly > just a rename for consistency, but also adds the 'never' option. > - Mark 'mailnotification' as deprecated in favor of 'notification-policy' > - Clarify that 'mailto' is ignored if 'notification-target' is set > > Signed-off-by: Lukas Wagner > --- > src/PVE/VZDump/Common.pm | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm > index a6fe483..31e9fdb 100644 > --- a/src/PVE/VZDump/Common.pm > +++ b/src/PVE/VZDump/Common.pm > @@ -167,16 +167,33 @@ my $confdesc = { > type => 'string', > format => 'email-or-username-list', > description => "Comma-separated list of email addresses or users that should" . > - " receive email notifications.", > + " receive email notifications. Has no effect if the 'notification-target' option " . > + " is set at the same time.", > optional => 1, > }, > mailnotification => { > type => 'string', > - description => "Specify when to send an email", > + description => "Deprecated: use 'notification-policy' instead.", > optional => 1, > enum => [ 'always', 'failure' ], > default => 'always', > }, > + 'notification-policy' => { > + type => 'string', > + description => "Specify when to send a notification", > + optional => 1, > + enum => [ 'always', 'failure', 'never'], > + default => 'always', > + }, > + 'notification-target' => { > + type => 'string', > + format => 'pve-configid', > + description => "Determine the target to which notifications should be sent." . > + " Can either be a notification endpoint or a notification group." . > + " This option takes precedence over 'mailto', meaning that if both are " . > + " set, the 'mailto' option will be ignored.", > + optional => 1, > + }, > tmpdir => { > type => 'string', > description => "Store temporary files to specified directory.", > -- > 2.39.2