From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3A1961FF17A for ; Fri, 4 Jul 2025 18:31:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ADCFB3BD25; Fri, 4 Jul 2025 18:31:42 +0200 (CEST) Date: Fri, 4 Jul 2025 18:31:07 +0200 From: Gabriel Goller To: Wolfgang Bumiller Message-ID: Mail-Followup-To: Wolfgang Bumiller , pve-devel@lists.proxmox.com References: <20250702145101.894299-1-g.goller@proxmox.com> <20250702145101.894299-34-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.164 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.218 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [fabrics.rs] Subject: Re: [pve-devel] [PATCH proxmox-perl-rs v4 5/5] pve-rs: sdn: fabrics: add helper for network API endpoint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" >> diff --git a/pve-rs/src/bindings/sdn/fabrics.rs b/pve-rs/src/bindings/sdn/fabrics.rs >> index 099c1a7ab515..f5abb1b72099 100644 >> --- a/pve-rs/src/bindings/sdn/fabrics.rs >> +++ b/pve-rs/src/bindings/sdn/fabrics.rs >> @@ -46,6 +46,34 @@ pub mod pve_rs_sdn_fabrics { >> >> perlmod::declare_magic!(Box : &PerlFabricConfig as "PVE::RS::SDN::Fabrics::Config"); >> >> + /// Represents a interface as returned by the `GET /nodes/{node}/network` endpoint in PVE. > >an* Done. >> + /// >> + /// This is used for returning fabrics in the endpoint, so they can be used from various places >> + /// in the PVE UI (e.g. migration network settings). >> + #[derive(Serialize, Deserialize)] > >It seems we currently only serialize this, so could drop the >`Deserialize` here since it's a private helper type anyway right now. Agree. >> + struct PveInterface { >> + iface: String, >> + #[serde(rename = "type")] >> + ty: String, >> + active: bool, >> + #[serde(skip_serializing_if = "Option::is_none")] >> + cidr: Option, >> + #[serde(skip_serializing_if = "Option::is_none")] >> + cidr6: Option, >> + } >> + >> + impl From for PveInterface { >> + fn from(fabric: ConfigFabric) -> Self { >> + Self { >> + iface: fabric.id().to_string(), >> + ty: "fabric".to_string(), >> + active: true, >> + cidr: fabric.ip_prefix(), >> + cidr6: fabric.ip6_prefix(), >> + } >> + } >> + } >> + >> [snip] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel