From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CB44BD02D for ; Wed, 20 Sep 2023 11:53:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A681313E64 for ; Wed, 20 Sep 2023 11:52:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 20 Sep 2023 11:52:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C20804840D for ; Wed, 20 Sep 2023 11:52:41 +0200 (CEST) Date: Wed, 20 Sep 2023 11:52:41 +0200 From: Christoph Heiss To: Aaron Lauterer Cc: Proxmox VE development discussion Message-ID: References: <20230905132832.3179097-1-a.lauterer@proxmox.com> <20230905132832.3179097-4-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230905132832.3179097-4-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC installer 3/6] add answer file fetch script X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2023 09:53:12 -0000 I think this can be part of the auto-installer itself, instead of introducing another shell script somewhere. While yes, "do one thing and do it well", its a rather small part and not unreasonable to move it directly into the auto-installer. Or have a separate Rust-written executable for this, both have their own merits of course - just not shell :^) If and when we add other methods of retrieving the answer file (as illustrated in the cover letter), it makes sense to write this in a sensible language and have a modular architecture, rather than arcane shell scripting. (Apart from the fact that the latter might even be nearly impossible for some things.) On Tue, Sep 05, 2023 at 03:28:29PM +0200, Aaron Lauterer wrote: > > With the auto installer present, the crucial question is how we get the > answer file. This script implements the way of a local disk/partition > present, labelled 'proxmoxinst', lower or upper case, with the > 'answer.toml' file in the root directory. > > We either want to use it directly and call it from 'unconfigured.sh' or > see it as a first approach to showcase how it could be done. > > Signed-off-by: Aaron Lauterer > --- > start_autoinstall.sh | 50 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100755 start_autoinstall.sh > > [..]