From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6213A1FF144 for ; Tue, 24 Mar 2026 09:50:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CADFD79A2; Tue, 24 Mar 2026 09:51:13 +0100 (CET) Date: Tue, 24 Mar 2026 09:50:35 +0100 From: Arthur Bied-Charreton To: Lukas Wagner Subject: Re: [PATCH proxmox 2/7] notify (smtp): Introduce state module Message-ID: References: <20260213160415.609868-1-a.bied-charreton@proxmox.com> <20260213160415.609868-3-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774342189827 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.811 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LII3RZO66AZVHA6XHXZLBOEV5D2OGHQT X-Message-ID-Hash: LII3RZO66AZVHA6XHXZLBOEV5D2OGHQT X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Mar 23, 2026 at 01:26:05PM +0100, Lukas Wagner wrote: [...] > > + proxmox_sys::fs::ensure_dir_exists(parent, &context().secret_create_options(), false) > > + .map_err(|e| Error::ConfigSerialization(e.into()))?; > > I'm getting a "bad permissions on "/etc/pve/priv/notifications" (0o700 > != 0o600)" error in the system/task logs when the token is refreshed. > The CreateOptions provided by the context are 0o600, but I think pmxcfs > automatically enforces the x-bit on directories, leading to 0o700 perms > on the '/etc/pve/priv/notifications/' directory, which ultimately gives > us this error. I think you either have to add a separate trait method > for the directory permissions/CreateOptions, or add the x-bit to the > existing CreateOptions yourself here at the callsite. > Just looked into that, there is a `create_secret_dir` function in `proxmox-product-config` that does exactly what we need here. > > + > > + let s = serde_json::to_string_pretty(&self) > > + .map_err(|e| Error::ConfigSerialization(e.into()))?; > > + > > + proxmox_sys::fs::replace_file(path, s.as_bytes(), context().secret_create_options(), true) > > + .map_err(|e| Error::ConfigSerialization(e.into())) > > + } > > + > > + /// Set `last_refreshed`. > > + pub(crate) fn set_last_refreshed(mut self, last_refreshed: i64) -> Self { > > + self.last_refreshed = last_refreshed; > > + self > > + } > > + > > + /// Set `oauth2_refresh_token`. > > + pub(crate) fn set_oauth2_refresh_token(mut self, oauth2_refresh_token: Option) -> Self { > > + self.oauth2_refresh_token = oauth2_refresh_token; > > + self > > + } > > +} >