From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 70AE01FF15E for ; Mon, 22 Dec 2025 12:23:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D4E9B12359; Mon, 22 Dec 2025 12:24:14 +0100 (CET) Date: Mon, 22 Dec 2025 12:23:38 +0100 From: Wolfgang Bumiller To: Kefu Chai Message-ID: References: <20251113021401.1587370-1-k.chai@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1766402601938 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [188.114.96.3] Subject: Re: [pve-devel] [PATCH proxmox-fuse-rs] add explicit "C" ABI to all extern function declarations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon, Dec 15, 2025 at 02:52:53PM +0800, Kefu Chai wrote: > + Wolfgang, > > ping? > > Hi Wolfgang, > > I wanted tp follow up on the patch I submitted about a month ago. > > I haven't received any feedback yet and wanted to check if there are any > concerns with the change or if any changes are needed. I'm happy to > revise the patch or provide additional information if that would be > helpful. I'm currently on parental leave and only working a few hours. Looking at them today. > > Thanks for your time and for maintaining this project! > > Regards, > > On Thu Nov 13, 2025 at 10:13 AM CST, Kefu Chai wrote: > > This fixes deprecation warnings where extern function declarations > > did not explicitly specify the ABI. All extern fn types in the > > FUSE Operations struct now use `extern "C" fn` instead of `extern fn`. > > > > The C ABI is required for FUSE callbacks that interface with the > > native libfuse library. > > > > Signed-off-by: Kefu Chai > > --- > > src/sys.rs | 86 +++++++++++++++++++++++++++--------------------------- > > 1 file changed, 43 insertions(+), 43 deletions(-) > > > > diff --git a/src/sys.rs b/src/sys.rs > > index a08eece..17a01de 100644 > > --- a/src/sys.rs > > +++ b/src/sys.rs > > @@ -113,49 +113,49 @@ default_to_none! { > > // The order in which the functions are listed matters, as the offset in the > > // struct defines what function the fuse driver uses. > > // It should therefore not be altered! > > - pub init: Option, > > - pub destroy: Option, > > - pub lookup: Option, > > - pub forget: Option, > > - pub getattr: Option, > > - pub setattr: Option, > > - pub readlink: Option, > > - pub mknod: Option, > > - pub mkdir: Option, > > - pub unlink: Option, > > - pub rmdir: Option, > > - pub symlink: Option, > > - pub rename: Option, > > - pub link: Option, > > - pub open: Option, > > - pub read: Option, > > - pub write: Option, > > - pub flush: Option, > > - pub release: Option, > > - pub fsync: Option, > > - pub opendir: Option, > > - pub readdir: Option, > > - pub releasedir: Option, > > - pub fsyncdir: Option, > > - pub statfs: Option, > > - pub setxattr: Option, > > - pub getxattr: Option, > > - pub listxattr: Option, > > - pub removexattr: Option, > > - pub access: Option, > > - pub create: Option, > > - pub getlk: Option, > > - pub setlk: Option, > > - pub bmap: Option, > > - pub ioctl: Option, > > - pub poll: Option, > > - pub write_buf: Option, > > - pub retrieve_reply: Option, > > - pub forget_multi: Option, > > - pub flock: Option, > > - pub fallocate: Option, > > - pub readdirplus: Option, > > - pub copy_file_range: Option, > > + pub init: Option, > > + pub destroy: Option, > > + pub lookup: Option, > > + pub forget: Option, > > + pub getattr: Option, > > + pub setattr: Option, > > + pub readlink: Option, > > + pub mknod: Option, > > + pub mkdir: Option, > > + pub unlink: Option, > > + pub rmdir: Option, > > + pub symlink: Option, > > + pub rename: Option, > > + pub link: Option, > > + pub open: Option, > > + pub read: Option, > > + pub write: Option, > > + pub flush: Option, > > + pub release: Option, > > + pub fsync: Option, > > + pub opendir: Option, > > + pub readdir: Option, > > + pub releasedir: Option, > > + pub fsyncdir: Option, > > + pub statfs: Option, > > + pub setxattr: Option, > > + pub getxattr: Option, > > + pub listxattr: Option, > > + pub removexattr: Option, > > + pub access: Option, > > + pub create: Option, > > + pub getlk: Option, > > + pub setlk: Option, > > + pub bmap: Option, > > + pub ioctl: Option, > > + pub poll: Option, > > + pub write_buf: Option, > > + pub retrieve_reply: Option, > > + pub forget_multi: Option, > > + pub flock: Option, > > + pub fallocate: Option, > > + pub readdirplus: Option, > > + pub copy_file_range: Option, > > } > > } > > > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel