From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 64F291FF0AE
	for <inbox@lore.proxmox.com>; Tue, 29 Sep 2026 15:26:53 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 5191821655;
	Tue, 29 Sep 2026 15:26:51 +0200 (CEST)
Date: Tue, 29 Sep 2026 15:26:44 +0200
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH] api: aliases: make 'cidr' optional when updating
Message-ID: <ojbfoyrm4gib5wwmwcmyeza6kax4a7omz7wpky3xrxm56hzvnu@4kbyfi5ekiy2>
References: <20260929132346.478117-1-a.bied-charreton@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260929132346.478117-1-a.bied-charreton@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1790688405786
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     1.331 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: MVXWOQRV6AITBFMULXUQPAKKYITFDBIP
X-Message-ID-Hash: MVXWOQRV6AITBFMULXUQPAKKYITFDBIP
X-MailFrom: a.bied-charreton@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Tue, Sep 29, 2026 at 03:23:46PM +0200, Arthur Bied-Charreton wrote:
> Updating an alias required passing its CIDR, even when only renaming it.
> Clients therefore had to fetch the alias first just to send back the
> currently configured CIDR.
> 
> Make 'cidr' optional in PUT .../firewall/aliases/{name} and keep the
> existing CIDR if none is passed.
> 
forgot to add the subject prefix, sorry for the noise
superseded by:
https://lore.proxmox.com/pve-devel/20260929132534.479718-1-a.bied-charreton@proxmox.com/T/#u