From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9DC7BE916 for ; Wed, 19 Jul 2023 14:09:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8883B6A44 for ; Wed, 19 Jul 2023 14:09:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Jul 2023 14:09:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 104CF41019 for ; Wed, 19 Jul 2023 14:09:18 +0200 (CEST) Date: Wed, 19 Jul 2023 14:09:17 +0200 From: Wolfgang Bumiller To: Lukas Wagner Cc: pve-devel@lists.proxmox.com Message-ID: References: <20230717150051.710464-1-l.wagner@proxmox.com> <20230717150051.710464-7-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.118 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v3 proxmox 06/66] notify: api: add API for sendmail endpoints X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2023 12:09:22 -0000 On Wed, Jul 19, 2023 at 01:51:33PM +0200, Lukas Wagner wrote: > > > On 7/18/23 14:36, Wolfgang Bumiller wrote: > > > + > > > +/// Get sendmail endpoint with given `name`. > > > +/// > > > +/// The caller is responsible for any needed permission checks. > > > +/// Returns the endpoint or an `ApiError` if the endpoint was not found. > > > +pub fn get_endpoint(config: &Config, name: &str) -> Result { > > > + config > > > + .config > > > + .lookup(SENDMAIL_TYPENAME, name) > > > + .map_err(|_| ApiError::not_found(format!("endpoint '{name}' not found"), None)) > > > > ^ Technically `.lookup()` could have found the name but as a wrong type. > > It might make sense to not use `.lookup()` in this case. > > > > `.lookup()` should be fine here from what I can tell. I actually want a `not found` if there is > another endpoint with that name but a different type, because the endpoints have a distinct > typed path prefix in the REST API: > > GET endpoints/sendmail/ > GET endpoints/gotify/ Fair enough.