From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E5D281FF2AB for ; Wed, 17 Jul 2024 14:51:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A33803B8F3; Wed, 17 Jul 2024 14:51:52 +0200 (CEST) Date: Wed, 17 Jul 2024 14:51:48 +0200 From: Christoph Heiss Cc: Proxmox VE development discussion Message-ID: References: <20240717124952.1027784-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240717124952.1027784-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.490 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment MISSING_HEADERS 1.021 Missing To: header SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH manager 1/2] www: utils: fix `maxcpu` validity check in render_hostcpu() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Should be marked [v2] obviously, with v1 here [0]. Sorry for the noise, noticed it only after hitting send. [0] https://lists.proxmox.com/pipermail/pve-devel/2024-July/064681.html On Wed, Jul 17, 2024 at 02:49:50PM GMT, Christoph Heiss wrote: > Comparing with Proxmox.Utils.render_cpu() seems just a slight oversight > in the condition. Fix it by aligning it with how it is done in > Proxmox.Utils.render_cpu() for consistency. > > Signed-off-by: Christoph Heiss > --- > www/manager6/Utils.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index f5608944d..ddef11bb1 100644 > --- a/www/manager6/Utils.js > +++ b/www/manager6/Utils.js > @@ -1073,7 +1073,7 @@ Ext.define('PVE.Utils', { > } > var maxcpu = node.data.maxcpu || 1; > > - if (!Ext.isNumeric(maxcpu) && (maxcpu >= 1)) { > + if (!Ext.isNumeric(maxcpu) || maxcpu < 1) { > return ''; > } > > -- > 2.45.1 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel