From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 42D101FF138 for ; Wed, 18 Feb 2026 10:55:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A9F81722D; Wed, 18 Feb 2026 10:56:25 +0100 (CET) Date: Wed, 18 Feb 2026 10:56:21 +0100 From: Gabriel Goller To: Hannes Laimer Subject: Re: [PATCH pve-network] sdn: controller: fallback to interface mac if no master Message-ID: Mail-Followup-To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260213063305.1979-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260213063305.1979-1-h.laimer@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771408574215 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.503 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] Message-ID-Hash: 7DJJIAJB5A4443EWPJQ6BLBUFRGZA7FW X-Message-ID-Hash: 7DJJIAJB5A4443EWPJQ6BLBUFRGZA7FW X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 13.02.2026 07:33, Hannes Laimer wrote: > For IPv6 underlays, we can't directly use the IP for the router-id. > Therefore, `get_router_id` derives a unique ID from the last 4 bytes of > the interface MAC. > > However, the current MAC retrieval logic only checks the master device. > This fails for standalone interfaces that do not have a master, such as > `dummy_` interfaces used for fabrics. > > Update `read_iface_mac` to fall back to the interface's own address if > no master address is found. > > Signed-off-by: Hannes Laimer > --- LGTM! Consider: Reviewed-by: Gabriel Goller > src/PVE/Network/SDN/Controllers/Plugin.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/Network/SDN/Controllers/Plugin.pm b/src/PVE/Network/SDN/Controllers/Plugin.pm > index d70e518..cab036a 100644 > --- a/src/PVE/Network/SDN/Controllers/Plugin.pm > +++ b/src/PVE/Network/SDN/Controllers/Plugin.pm > @@ -105,7 +105,9 @@ sub on_update_hook { > > sub read_iface_mac { > my ($iface) = @_; > - return PVE::Tools::file_read_firstline("/sys/class/net/$iface/master/address"); > + my $mac = PVE::Tools::file_read_firstline("/sys/class/net/$iface/master/address"); > + return $mac if $mac; > + return PVE::Tools::file_read_firstline("/sys/class/net/$iface/address"); > } > > sub get_router_id { > -- > 2.47.3