From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 86107ED59 for ; Thu, 20 Jul 2023 15:30:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67DB8133A2 for ; Thu, 20 Jul 2023 15:30:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 20 Jul 2023 15:30:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 70B7541E1E for ; Thu, 20 Jul 2023 15:30:21 +0200 (CEST) Date: Thu, 20 Jul 2023 15:30:20 +0200 From: Christoph Heiss To: Friedrich Weber Cc: Proxmox VE development discussion Message-ID: References: <20230719155157.696828-1-c.heiss@proxmox.com> <7e04b1df-0c19-f44c-bfaa-66d35890602d@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e04b1df-0c19-f44c-bfaa-66d35890602d@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH common/access-control 0/5] improve LDAP DN and bind creds checking on creation/change X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jul 2023 13:30:52 -0000 Thanks for taking a look and testing this! On Thu, Jul 20, 2023 at 02:42:10PM +0200, Friedrich Weber wrote: > > Tested against slapd 2.4.47+dfsg-3+deb10u6. I quite like the connection > check when creating/updating the realm, and also, it seems sensible to > delegate DN validation to Net::LDAP. > > I noticed one bug: Weirdly, updating the realm via CLI or manually via > API now errors out for me (the connection details are correct): I only tested it via the UI, definitely a good catch. > > $ cat /etc/pve/domains.cfg > pam: pam > comment Linux PAM standard authentication > > pve: pve > comment Proxmox VE authentication server > default 0 > > ldap: ldap > comment foo > base_dn dc=example,dc=com > server1 [...] > user_attr uid > bind_dn cn=admin,dc=example,dc=com > default 0 > secure 0 > > $ pveum realm modify ldap -comment foo > update auth server failed: Expected 'PeerHost' at > /usr/share/perl5/Net/LDAP.pm line 173. Weird. That error doesn't really match up with anything on my machine in that file - what version of the `libnet-ldap-perl` package do you have installed exactly? Because I cannot seem to reproduce that error on my machine, both `pveum` and `pvesh` work just fine for me. > > $ http --verify no PUT > 'https://[...]:8006/api2/json/access/domains/ldap' comment=foo [...] > HTTP/1.1 500 update auth server failed: Expected 'PeerHost' at > /usr/share/perl5/Net/LDAP.pm line 173. > > On 19/07/2023 17:51, Christoph Heiss wrote: > [..]