From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D33A99531C for ; Mon, 26 Feb 2024 10:05:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 784A5B98D for ; Mon, 26 Feb 2024 10:04:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 26 Feb 2024 10:04:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6D01A471F2 for ; Mon, 26 Feb 2024 10:04:50 +0100 (CET) Date: Mon, 26 Feb 2024 10:04:49 +0100 From: Christoph Heiss To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: References: <20240215124004.1197676-1-c.heiss@proxmox.com> <20240215124004.1197676-6-c.heiss@proxmox.com> <2916160f-a162-4fe5-98ef-97b2e44745fc@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2916160f-a162-4fe5-98ef-97b2e44745fc@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer 5/5] fix #5230: sys: net: properly escape FQDN regex X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2024 09:05:22 -0000 On Fri, Feb 23, 2024 at 05:27:52PM +0100, Thomas Lamprecht wrote: > Am 15/02/2024 um 13:39 schrieb Christoph Heiss: > > Due to interpolation, the \. sequence must be double-escaped. > > Previously, this would result in a non-escaped dot, thus matching much > > more liberally than it should. > > > > OK, but... > > > > diff --git a/proxmox-installer-common/src/utils.rs b/proxmox-installer-common/src/utils.rs > > index 0ed7438..03efdd7 100644 > > --- a/proxmox-installer-common/src/utils.rs > > +++ b/proxmox-installer-common/src/utils.rs > > @@ -309,6 +309,12 @@ mod tests { > > Fqdn::from(&format!("{}.com", "a".repeat(64))), > > Err(InvalidPart("a".repeat(64))), > > ); > > + > > + // https://bugzilla.proxmox.com/show_bug.cgi?id=3497 > > ...why link on a feature request for terraform support then? Whoop, sorry for that - apparently had the wrong link in the the clipboard when writing this .. > > > > diff --git a/test/parse-fqdn.pl b/test/parse-fqdn.pl > > index 3009984..df8739d 100755 > > --- a/test/parse-fqdn.pl > > +++ b/test/parse-fqdn.pl > > @@ -51,4 +51,7 @@ is_parsed('a' x 63 . '.com', ['a' x 63, 'com']); > > is_invalid('a' x 250 . '.com', ERR_TOOLONG); > > is_invalid('a' x 64 . '.com', ERR_ALPHANUM); > > > > +# https://bugzilla.proxmox.com/show_bug.cgi?id=3497 > > same here