From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8B0791FF164 for <inbox@lore.proxmox.com>; Wed, 25 Sep 2024 16:01:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA079314A5; Wed, 25 Sep 2024 16:01:14 +0200 (CEST) Date: Wed, 25 Sep 2024 16:01:08 +0200 From: Christoph Heiss <c.heiss@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <nxail4lfngdcdf5zyodmodpbmxv2hqcktdfbjcykrn5diycbfw@bvckjcozmxeo> References: <20240821132307.1352643-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240821132307.1352643-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, config.pm, parse-kernel-cmdline.pl] Subject: Re: [pve-devel] [PATCH installer v2 0/3] properly filter out all installer-related kernel arguments X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Ping, still applies on latest master. On Wed, Aug 21, 2024 at 03:22:59PM GMT, Christoph Heiss wrote: > Friedrich recently reported that when installing using the > auto-installer, the kernel commandline does not get cleaned up properly. > > For building/testing on current master, [0] needs to be applied > beforehand to fix a test failure. > > [0] https://lists.proxmox.com/pipermail/pve-devel/2024-July/064815.html FWIW, this patch has been applied in the meantime [0] and is thus no longer needed as a prerequisite. [0] https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=0c9a7003f > > history > ======= > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-August/065070.html > > Notable changes v1 -> v2: > * parse whole line by splitting and then filtering out individually > * add some tests > > git diffstat > ============ > > Christoph Heiss (3): > low level: config: filter out kernel cmdline on word boundaries > low level: config: filter out all installer-related kernel arguments > test: add test for kernel commandline parsing > > Proxmox/Install/Config.pm | 11 ++++--- > test/Makefile | 7 +++- > test/parse-kernel-cmdline.pl | 62 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 75 insertions(+), 5 deletions(-) > create mode 100755 test/parse-kernel-cmdline.pl > > -- > 2.45.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel