From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8E02A1FF2CA for ; Tue, 23 Jul 2024 12:45:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B3D86D77; Tue, 23 Jul 2024 12:46:27 +0200 (CEST) Date: Tue, 23 Jul 2024 12:46:24 +0200 From: Christoph Heiss To: Aaron Lauterer Message-ID: References: <20240718134905.1177775-1-c.heiss@proxmox.com> <20240718134905.1177775-12-c.heiss@proxmox.com> <4b74a294-7897-4499-a707-161a760baf1d@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4b74a294-7897-4499-a707-161a760baf1d@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [parse-answer.rs, proxmox.com] Subject: Re: [pve-devel] [PATCH installer v2 11/17] auto-installer: tests: replace manual panic!() with assert_eq!() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, Jul 23, 2024 at 12:39:20PM GMT, Aaron Lauterer wrote: > Do we still see which test case actually failed? IIRC I used the panic so I > can print the needed info, mainly the name of the current test scenario so > it is easier to find out which failed. Yes, since it printed earlier in the code, at the start of the `if extension == "toml" { .. }` block. > > On 2024-07-18 15:48, Christoph Heiss wrote: > > Signed-off-by: Christoph Heiss > > --- > > Changes v1 -> v2: > > * new patch, suggested by Stefan > > --- > > proxmox-auto-installer/tests/parse-answer.rs | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/proxmox-auto-installer/tests/parse-answer.rs b/proxmox-auto-installer/tests/parse-answer.rs > > index 450915a..1fc515e 100644 > > --- a/proxmox-auto-installer/tests/parse-answer.rs > > +++ b/proxmox-auto-installer/tests/parse-answer.rs > > @@ -75,12 +75,8 @@ fn test_parse_answers() { > > path.push(format!("{name}.json")); > > let compare_raw = std::fs::read_to_string(&path).unwrap(); > > let compare: Value = serde_json::from_str(&compare_raw).unwrap(); > > - if config != compare { > > - panic!( > > - "Test {} failed:\nleft: {:#?}\nright: {:#?}\n", > > - name, config, compare > > - ); > > - } > > + > > + assert_eq!(config, compare); > > } > > } > > } > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel