From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5805F1FF2C6 for ; Wed, 10 Jul 2024 15:59:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34495B1CE; Wed, 10 Jul 2024 15:59:41 +0200 (CEST) Date: Wed, 10 Jul 2024 15:59:36 +0200 From: Christoph Heiss To: Aaron Lauterer Message-ID: References: <20240710124300.295817-1-a.lauterer@proxmox.com> <20240710124300.295817-3-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240710124300.295817-3-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 2/2] fix#5570 ui: ceph: make MDS ID configurable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed, Jul 10, 2024 at 02:43:00PM GMT, Aaron Lauterer wrote: > [..] > www/manager6/ceph/ServiceList.js | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/www/manager6/ceph/ServiceList.js b/www/manager6/ceph/ServiceList.js > index 76710146..9075f197 100644 > --- a/www/manager6/ceph/ServiceList.js > +++ b/www/manager6/ceph/ServiceList.js > [..] > @@ -40,15 +39,17 @@ Ext.define('PVE.CephCreateService', { > listeners: { > change: function(f, value) { > let view = this.up('pveCephCreateService'); > + view.lookup('mds-id').setValue(value); > view.setNode(value); > }, > }, > }, > { > xtype: 'textfield', > - fieldLabel: gettext('Extra ID'), > - regex: /[a-zA-Z0-9]+/, > - regexText: gettext('ID may only consist of alphanumeric characters'), > + reference: 'mds-id', > + fieldLabel: gettext('MDS ID'), > + regex: /^([a-zA-Z]([-a-zA-Z0-9]*[a-zA-Z0-9])?)$/, > + regexText: gettext('ID may consist of alphanumeric characters and hyphen. It cannot start with a number or end in a hyphen.'), Is there a check in the backend whether the name ends with a hyphen? If not, should there be one? Also, while at it, maybe also set `maxLength` to a sensible value? E.g. while the API schema allows up to 200 characters, it then fails to create a task log file with "File name too long" :^) ~ 180 characters seem to be fine, but probably something like 128 characters is already a pretty sensible limit. > submitValue: false, > emptyText: Proxmox.Utils.NoneText, > cbind: { > @@ -58,7 +59,7 @@ Ext.define('PVE.CephCreateService', { > listeners: { > change: function(f, value) { > let view = this.up('pveCephCreateService'); > - view.setExtraID(value); > + view.setServiceID(value); > }, > }, > }, > @@ -73,7 +74,7 @@ Ext.define('PVE.CephCreateService', { > cbind: { > hidden: get => get('type') !== 'mds', > }, > - html: gettext('The Extra ID allows creating multiple MDS per node, which increases redundancy with more than one CephFS.'), > + html: gettext('By using different IDs, you can have multiple MDS per node, which increases redundancy with more than one CephFS.'), > }, > ], > > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel