From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 46D521FF165 for <inbox@lore.proxmox.com>; Thu, 10 Apr 2025 14:07:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 41E423A4A7; Thu, 10 Apr 2025 14:07:01 +0200 (CEST) Date: Thu, 10 Apr 2025 14:06:22 +0200 To: Lukas Wagner <l.wagner@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20250408121312.312526-1-d.csapak@proxmox.com> <c7b3dfb5-89aa-4f42-927d-08475d17e7f0@proxmox.com> In-Reply-To: <c7b3dfb5-89aa-4f42-927d-08475d17e7f0@proxmox.com> MIME-Version: 1.0 Message-ID: <mailman.912.1744286820.359.pve-devel@lists.proxmox.com> List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Post: <mailto:pve-devel@lists.proxmox.com> From: Dominik Csapak via pve-devel <pve-devel@lists.proxmox.com> Precedence: list Cc: Dominik Csapak <d.csapak@proxmox.com> X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> Subject: Re: [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI Content-Type: multipart/mixed; boundary="===============8796716294718496954==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> --===============8796716294718496954== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: <d.csapak@proxmox.com> X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 706A3D3FF9 for <pve-devel@lists.proxmox.com>; Thu, 10 Apr 2025 14:06:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5285D3A423 for <pve-devel@lists.proxmox.com>; Thu, 10 Apr 2025 14:06:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 10 Apr 2025 14:06:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 960674419F; Thu, 10 Apr 2025 14:06:23 +0200 (CEST) Message-ID: <2ace65d7-641d-422d-83e8-e31f24d10a63@proxmox.com> Date: Thu, 10 Apr 2025 14:06:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI To: Lukas Wagner <l.wagner@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20250408121312.312526-1-d.csapak@proxmox.com> <c7b3dfb5-89aa-4f42-927d-08475d17e7f0@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <c7b3dfb5-89aa-4f42-927d-08475d17e7f0@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record On 4/10/25 14:04, Lukas Wagner wrote: > > > On 2025-04-08 14:13, Dominik Csapak wrote: >> this is a continuation of my previous series [0] >> >> It enables importing disks on the UI in the HardwareView of a vm, >> in the create wizard, and in the storage content view. >> >> I split the patches so that the wizard and storage content view one are >> separate, so they can be reviewed independently. >> > > Gave this a quick test on the latest pve-manager master branch. Seems to work as advertised. > Tried importing from the Create-VM wizard, by going to the Hardware tab a VM as well > as from the storage view itself. > > Noticed that under "Download from URL" there is no way to automatically extract compressed > images the same way as we do it for ISO images. Is there some technical reason for this? > Or is it just not implemented yet? Anyway, would be a nice addition for a > future patch series :) yeah, it's just not implemented yet, but it totally makes sense to have in the future Thanks for testing! > > Tested-by: Lukas Wagner <l.wagner@proxmox.com> > --===============8796716294718496954== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============8796716294718496954==--