From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2EC191FF165 for <inbox@lore.proxmox.com>; Thu, 10 Apr 2025 13:40:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C7723982F; Thu, 10 Apr 2025 13:40:46 +0200 (CEST) References: <20250408121312.312526-1-d.csapak@proxmox.com> <20250408121312.312526-4-d.csapak@proxmox.com> <a05bdfdc-dac0-4b8d-9d23-5913ca768c36@proxmox.com> <22a457f5-12ce-48f3-9dfa-d4ae90715670@proxmox.com> In-Reply-To: <22a457f5-12ce-48f3-9dfa-d4ae90715670@proxmox.com> Date: Thu, 10 Apr 2025 08:39:58 -0300 To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> MIME-Version: 1.0 Message-ID: <mailman.909.1744285245.359.pve-devel@lists.proxmox.com> List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Post: <mailto:pve-devel@lists.proxmox.com> From: Gilberto Ferreira via pve-devel <pve-devel@lists.proxmox.com> Precedence: list Cc: Gilberto Ferreira <gilberto.nunes32@gmail.com>, Thomas Lamprecht <t.lamprecht@proxmox.com> X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> Subject: Re: [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images Content-Type: multipart/mixed; boundary="===============6212454584549773488==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> --===============6212454584549773488== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: <gilberto.nunes32@gmail.com> X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7411BD3F34 for <pve-devel@lists.proxmox.com>; Thu, 10 Apr 2025 13:40:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 53093397CE for <pve-devel@lists.proxmox.com>; Thu, 10 Apr 2025 13:40:44 +0200 (CEST) Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 10 Apr 2025 13:40:43 +0200 (CEST) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-30f30200b51so6700311fa.3 for <pve-devel@lists.proxmox.com>; Thu, 10 Apr 2025 04:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744285236; x=1744890036; darn=lists.proxmox.com; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CTQ0sIio2ufVQYEWD/TmM5heyPhb90ZL1aRmt4sL2+c=; b=XlDUnQHRnWcArveqyE9Mn3O36jHMVkByI4MFUhHlsuzPjFuxLmhA+zUZmqJRjOwHYq q62a9GHJV2xe5Vy8206wYPoI+/zYa52lNvqyTB5EEsS9iWhGwS+j8sNqLD/t21naqT4r 0EwSdJc5pifn0pvigPDciImt6LQ+iiOVEKxcentNAoNHGNiq6o5o0AnYoLmQ/ifJcHaA YbtFVbllVMwAXN9b+PYS8ZQ0ZycOT382MGVBSptT8mciyuwQUKf007enUDv+vZlkiuaH dfT8g7cod9PisN5PHyOI5INSM6j/cSVUQnX9s/O+IxLXmR3NE5VMcuAEBfa4UWAsiqJp 80gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744285236; x=1744890036; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CTQ0sIio2ufVQYEWD/TmM5heyPhb90ZL1aRmt4sL2+c=; b=tXK1WOI26Uy8hVcKwvIEVXOv+VSqnBOuYFG86wxj6wfyCP/f5lZfCDY/gIA1TQ+Uvd zAXVL6lnb8IuhBJKGLM/4RNaNrPELJ/GmxswxOWY+PWbWM95bDIq8E1Q62B1ywiuvQLj x8esFtu44ZBzJJfA32A2CqDjbb4Cho3xWG1hC+rg9Un+wGjr/8zZLzUEyjJpRBrWq0RF s6Wuld1Edon59dHRtCqd69iW+rzOPTiSKA4J2/QD8msOrfmd9fttSyiPqJaQYkyTrOY9 knugNOulL9iEF/35WTAvv3UF0eHT2iTQPlUZg+dPuNHeMbDudgZpWTCHEZnq2bUKT85v rcwA== X-Gm-Message-State: AOJu0Ywiwl2rV13XCznBrO3Wl/INpLi5odmN/XgI0L94GZACN4/BUzoc uWtUt2/wvk71R9hXbvS0BcDcsiM+y2K4eLXrwhinaRn5l6ocGZHXe+KiNGCcwaJqY5IyFnoU96h 8hY8npURiaoQ/UlQxcKhV7mEjty4j8cLa X-Gm-Gg: ASbGncuBtvxr9ZPUstgbv/dWj1o0VjEyIlFj4PGTu9N7//TkOpkcsLzLDbRbJmi/rX2 WJqzKFdqKQRbrfJM/9vIzJ8ZmTOBvwWH7Iv+zES2FdcVzFdSG4QlZw7tWKLw4aQqX6U2HvhQHeX 1g6Bn46+k7N1bRbTxOl4MBOuMCsoYKmL9Nz/4= X-Google-Smtp-Source: AGHT+IHGkPUf8QwMYSV2UvNppk903ZZ/8ldoM1TV4docA67q5G9pABC1eL0OjjNsfmN1ZBD2L7FJdwNx+2SM3eeUY+8= X-Received: by 2002:a05:651c:1601:b0:30d:e104:9ad2 with SMTP id 38308e7fff4ca-3103ed525cdmr6595211fa.39.1744285235616; Thu, 10 Apr 2025 04:40:35 -0700 (PDT) MIME-Version: 1.0 References: <20250408121312.312526-1-d.csapak@proxmox.com> <20250408121312.312526-4-d.csapak@proxmox.com> <a05bdfdc-dac0-4b8d-9d23-5913ca768c36@proxmox.com> <22a457f5-12ce-48f3-9dfa-d4ae90715670@proxmox.com> In-Reply-To: <22a457f5-12ce-48f3-9dfa-d4ae90715670@proxmox.com> From: Gilberto Ferreira <gilberto.nunes32@gmail.com> Date: Thu, 10 Apr 2025 08:39:58 -0300 X-Gm-Features: ATxdqUGQGZOIETT6KBF7ER6RQAxUJi2g6t5E4fSOsY0SiqdV27eU0Mjr1_2tkqU Message-ID: <CAOKSTBsFSWxePJzuVY2UvWioNdrDOOHXyhjmAVBTYN9HtjbfAQ@mail.gmail.com> Subject: Re: [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 0.25 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider HTML_MESSAGE 0.001 HTML included in message POISEN_SPAM_PILL_4 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Hi folks. I tried this feature in the new Proxmox VE 8.4, I just can upload vmdk, qcow2 and raw file. Tried vhd and vdi and no luck. And I can't use the uploaded file to import the image and create a new VM. Is that supposed to be this way, at least for now? Is there any further development to be done? I suppose this is not a bug, right? But, instead, something to fully implement in next upgrades. Cheers. --- Gilberto Nunes Ferreira +55 (47) 99676-7530 - Whatsapp / Telegram Em qua., 9 de abr. de 2025 =C3=A0s 04:10, Dominik Csapak <d.csapak@proxmox.= com> escreveu: > On 4/8/25 17:34, Thomas Lamprecht wrote: > > Am 08.04.25 um 14:13 schrieb Dominik Csapak: > >> By enabling the import button for qcow2/vmdk/raw files, and showing a > >> window with a VMID selector and the disk edit panel. > >> > > functionality wise I'd have applied that as it would be new and have th= us > > almost no regression potential, might be also better to factor out the > > panel upfront in a dedicated commit and then integrate it everywhere. > > > > But lets wait this out, no point in rushing things here. > > Sure, don't rush this. Is there anything concrete you'd want to do have > done differently > here though? > > Even for the import storage content I'd really like to reuse the general > disk edit panel > (for e.g. the detection of which bus/controller is used, etc.), so the > regression potential > would be no different even if we'd only show it in the storage content. > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > --===============6212454584549773488== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============6212454584549773488==--