From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 98DA81FF163 for ; Thu, 26 Sep 2024 15:56:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BBBD19692; Thu, 26 Sep 2024 15:56:49 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Fri, 27 Sep 2024 01:52:27 +1200 MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Severen Redwood via pve-devel Precedence: list Cc: Severen Redwood X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH SERIES] Add ability to prevent suggesting previously used VM/CT IDs Content-Type: multipart/mixed; boundary="===============1120699678467060871==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============1120699678467060871== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7D3E0C13E0 for ; Thu, 26 Sep 2024 15:56:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5F67E947F for ; Thu, 26 Sep 2024 15:56:18 +0200 (CEST) Received: from mx3.ext.sitehost.co.nz (mx3.ext.sitehost.co.nz [120.138.20.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 26 Sep 2024 15:56:16 +0200 (CEST) Received: from localhost (extmx1-new.vps.sitehost.co.nz [127.0.0.1]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTP id F2EB2180A82; Fri, 27 Sep 2024 01:56:06 +1200 (NZST) X-Virus-Scanned: SiteHost Virus/Spam Prevention on mx3.ext.sitehost.co.nz X-Spam-Flag: NO X-Spam-Score: -3.449 X-Spam-Status: No, score=-3.449 tagged_above=-100 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.55, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx3.ext.sitehost.co.nz ([127.0.0.1]) by localhost (mx3.ext.sitehost.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mm1mTbNvI8Zn; Fri, 27 Sep 2024 01:56:01 +1200 (NZST) Received: from localhost.localdomain (oep.air.sitehost.co.nz [120.138.16.30]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTPSA id 94097180A21; Fri, 27 Sep 2024 01:55:59 +1200 (NZST) From: Severen Redwood To: pve-devel@lists.proxmox.com Subject: [PATCH SERIES] Add ability to prevent suggesting previously used VM/CT IDs Date: Fri, 27 Sep 2024 01:52:27 +1200 Message-ID: <20240926135516.117065-1-severen.redwood@sitehost.co.nz> X-Mailer: git-send-email 2.46.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.895 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_PASS -0.1 DMARC pass policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Hi everyone, This patch series is a reworking of Daniel Krambrock's patches [1] which allow for configuring the strategy used for suggesting VM IDs. As discussed with him [2], I have removed the 'max + 1' strategy as it is fundamentally flawed given that the goal is preventing re-use of IDs that can cause issues like #4369 [3]. This leaves two strategies, namely the current behaviour of suggesting the lowest free ID and the new optional behaviour of suggesting the lowest free *and* not previously used ID. Beyond this, I have also fixed a bug where IDs would be recorded as used multiple times and removed sorting the stored list of IDs on write as it is not required. I believe that the comments from Shannon Sterz relating to code style should now be addressed, though there is still their comment on tracking the used IDs in `/etc/pve/used_vmids.list`: > Not sure if tracking the used VM/CT IDs in a separate file is the most > elegant solution here. Especially as this is a somewhat niche usecase. If this needs to be changed, then where should it go? I am not familiar enough with the codebase to know what the preference would be. Note that we *must* store a list of used IDs rather than a simple counter because PVE allows you to choose any free ID you wish when creating a VM or container. As I re-wrote the commit messages and it felt strange to ghost-write messages under someone else's name, the commit author on all patches is myself with Daniel listed as a co-author using `Co-authored-by` trailers in the commit message bodies. Please let me know if this isn't the right convention :) I have also sent in a signed CLA to cover my contributions. Thanks, Severen [1]: https://lore.proxmox.com/pve-devel/D1RYIAHXBOIH.RM5K01KGND9T@proxmox.com/t/ [2]: https://lore.proxmox.com/pve-devel/mailman.472.1724973432.302.pve-devel@lists.proxmox.com/T/#u [3]: https://bugzilla.proxmox.com/show_bug.cgi?id=4369#c13 pve-manager ----------- Severen Redwood (2): close #4369: api: optionally only suggest unique close #4369: ui: add datacenter option for unique PVE/API2/Cluster.pm | 12 ++++++-- PVE/Makefile | 1 + PVE/UsedVmidList.pm | 55 +++++++++++++++++++++++++++++++++++ www/manager6/dc/OptionView.js | 4 +++ 4 files changed, 70 insertions(+), 2 deletions(-) create mode 100644 PVE/UsedVmidList.pm pve-container ------------- Severen Redwood (1): api: record CT ID as used after a container is destroyed src/PVE/API2/LXC.pm | 1 + 1 file changed, 1 insertion(+) qemu-server ----------- Severen Redwood (1): api: record VM ID as used after a virtual machine is destroyed PVE/API2/Qemu.pm | 1 + 1 file changed, 1 insertion(+) pve-cluster ----------- Severen Redwood (2): cluster files: add used_vmids.list datacenter config: add unique-next-id to schema src/PVE/Cluster.pm | 1 + src/PVE/DataCenterConfig.pm | 5 +++++ src/pmxcfs/status.c | 1 + 3 files changed, 7 insertions(+) --===============1120699678467060871== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============1120699678467060871==--