From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E8F0F1FF163 for ; Thu, 26 Sep 2024 15:56:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A10EB95D9; Thu, 26 Sep 2024 15:56:45 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Fri, 27 Sep 2024 01:52:31 +1200 In-Reply-To: <20240926135516.117065-1-severen.redwood@sitehost.co.nz> References: <20240926135516.117065-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Severen Redwood via pve-devel Precedence: list Cc: Severen Redwood X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH qemu-server] api: record VM ID as used after a virtual machine is destroyed Content-Type: multipart/mixed; boundary="===============3083974744113477381==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============3083974744113477381== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A195EC13DA for ; Thu, 26 Sep 2024 15:56:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8AB9B9621 for ; Thu, 26 Sep 2024 15:56:44 +0200 (CEST) Received: from mx3.ext.sitehost.co.nz (mx3.ext.sitehost.co.nz [120.138.20.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 26 Sep 2024 15:56:43 +0200 (CEST) Received: from localhost (extmx1-new.vps.sitehost.co.nz [127.0.0.1]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTP id B93CD180773; Fri, 27 Sep 2024 01:56:26 +1200 (NZST) X-Virus-Scanned: SiteHost Virus/Spam Prevention on mx3.ext.sitehost.co.nz X-Spam-Flag: NO X-Spam-Score: -3.449 X-Spam-Status: No, score=-3.449 tagged_above=-100 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.55, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx3.ext.sitehost.co.nz ([127.0.0.1]) by localhost (mx3.ext.sitehost.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U7VMxdjuXLY8; Fri, 27 Sep 2024 01:56:22 +1200 (NZST) Received: from localhost.localdomain (oep.air.sitehost.co.nz [120.138.16.30]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTPSA id D09BC180B3E; Fri, 27 Sep 2024 01:56:22 +1200 (NZST) From: Severen Redwood To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] api: record VM ID as used after a virtual machine is destroyed Date: Fri, 27 Sep 2024 01:52:31 +1200 Message-ID: <20240926135516.117065-5-severen.redwood@sitehost.co.nz> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20240926135516.117065-1-severen.redwood@sitehost.co.nz> References: <20240926135516.117065-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.298 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_PASS -0.1 DMARC pass policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record After a virtual machine is destroyed, record that its ID has been used via the `PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can later optionally avoid suggesting previously used IDs. Co-authored-by: Daniel Krambrock Signed-off-by: Severen Redwood --- PVE/API2/Qemu.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index d25a79fe..67a6191f 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2340,6 +2340,7 @@ __PACKAGE__->register_method({ }); }; + PVE::UsedVmidList::add_vmid($vmid); return $rpcenv->fork_worker('qmdestroy', $vmid, $authuser, $realcmd); }}); -- 2.46.2 --===============3083974744113477381== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============3083974744113477381==--