From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 8AB751FF162
for <inbox@lore.proxmox.com>; Sat, 22 Mar 2025 16:26:06 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id DCD5C3BE60;
Sat, 22 Mar 2025 16:26:04 +0100 (CET)
To: pve-devel@lists.proxmox.com
Date: Sun, 23 Mar 2025 00:17:09 +0900
In-Reply-To: <20250322152004.1646886-1-jing@jing.rocks>
References: <20250322152004.1646886-1-jing@jing.rocks>
MIME-Version: 1.0
Message-ID: <mailman.80.1742657164.359.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Jing Luo via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Jing Luo <jing@jing.rocks>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to
/run/lock/vzdump.lock
Content-Type: multipart/mixed; boundary="===============6962662411069549652=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
--===============6962662411069549652==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <jing@jing.rocks>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 347BDC93B1
for <pve-devel@lists.proxmox.com>; Sat, 22 Mar 2025 16:26:03 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 126873BD56
for <pve-devel@lists.proxmox.com>; Sat, 22 Mar 2025 16:25:33 +0100 (CET)
Received: from mail-gw3.jing.rocks (mail-gw3.jing.rocks [219.117.250.209])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Sat, 22 Mar 2025 16:25:28 +0100 (CET)
Received: from mail-gw3.jing.rocks (localhost [127.0.0.1])
by mail-gw3.jing.rocks (Proxmox) with ESMTP id EE23A165BE
for <pve-devel@lists.proxmox.com>; Sun, 23 Mar 2025 00:20:16 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jing.rocks; h=cc
:cc:content-transfer-encoding:date:from:from:in-reply-to
:message-id:mime-version:references:reply-to:subject:subject:to
:to; s=mail-gw; bh=6qmQ4yNJXVRQGIB/vxOTKKfxDA0z2oR6iB54CTDu3OQ=; b=
CtVt8UPlns0myCB3u545dQ9p47XkUr2QuMTUbBPEQUqJTvXrEYpYqUwX4fH85zlX
ePSa1Po6yUoVoXH9SmDycZgk4R/C2fLlvGLqFaHQPHz33c8HgXJ/k9wQhh9pHFaK
opKSo+j7HY9BOp+RRtmeg3BEAXlfg9fNucPRBK2Drys41VDdssm+UJ3c9PHtk2M/
Q8cZJTchK96fmjzXf9GFG1uzZABa6B31BTAkW7XWLd8Nlfh11WRhGZRsKd5OiZoO
GP/Kv+1FMWQR7JcBCe7RVs6D/FRgCR+hzkMYsUNNm8Q+kZSJyhjzsOaqBe3q6bZ1
BvCb8LiQGf+nRkAHLX7DGA==
Received: from mail.jing.rocks (mail.jing.rocks [192.168.0.222])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by mail-gw3.jing.rocks (Proxmox) with ESMTPS id 3093C164DF
for <pve-devel@lists.proxmox.com>; Sun, 23 Mar 2025 00:20:16 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jing.rocks;
s=default; t=1742656816;
bh=9gQhHhRPRIBE8CVs8ap1qqrKPnF4MB5YcWoH3Geoga4=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=wSBe6WPz69H6t0kdE2FmfBqLrkBHDmeaQ1mDRarfzRJ9OZS6Q0s7KDQe6E3b+Vsh4
mcppUDwaGMBTfOXhZNWGTC4nS2ljHih+3mp6ocyAPOMfPdOShq2oO4cg8Oauggcf2P
nJESyjiCWv10ursV9w4vemcK6pHnlWuNiTrRqe3p6o8Vax2cveB1bcFnBIdeFctJW5
mhucSjJ53vz9gLos1Za5DMz4YynCUBUOVYLPc3w3biZdHBq23lMWu6wrVn1qDPgFOa
XUjLy2LPUZFioTYH+afXnCuRV+MB3wng4Nwk84EcmUX2ieeThc8c43IXFg6x+tTblh
n5mmUg5G9AQtA==
Received: from X570AM.jing.rocks (X570AM.lan [IPv6:240b:10:f00:1b00::7e82])
(Authenticated sender: jing@jing.rocks)
by mail.jing.rocks (Postfix) with ESMTPSA id 2A9D13807E;
Sun, 23 Mar 2025 00:20:16 +0900 (JST)
From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock
Date: Sun, 23 Mar 2025 00:17:09 +0900
Message-ID: <20250322152004.1646886-2-jing@jing.rocks>
X-Mailer: git-send-email 2.49.0
In-Reply-To: <20250322152004.1646886-1-jing@jing.rocks>
References: <20250322152004.1646886-1-jing@jing.rocks>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.001 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain
DMARC_PASS -0.1 DMARC pass policy
KAM_INFOUSMEBIZ 0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware
KAM_OTHER_BAD_TLD 0.75 Other untrustworthy TLDs
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
It's more appropriate under Debian, and vzdump.lock doesn't seem to
be used by any other package.
Signed-off-by: Jing Luo <jing@jing.rocks>
---
PVE/API2/Nodes.pm | 2 +-
PVE/VZDump.pm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 3708eb26..637479ea 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -1978,7 +1978,7 @@ __PACKAGE__->register_method ({
}
eval { # remove backup locks, but avoid running into a scheduled backup job
- PVE::Tools::lock_file('/run/vzdump.lock', 10, $remove_locks_on_startup, $nodename);
+ PVE::Tools::lock_file('/run/lock/vzdump.lock', 10, $remove_locks_on_startup, $nodename);
};
warn $@ if $@;
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 5178ce9d..dce1bcc4 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -40,7 +40,7 @@ PVE::JSONSchema::register_standard_option('pve-backup-jobid', {
my @posix_filesystems = qw(ext3 ext4 nfs nfs4 reiserfs xfs);
-my $lockfile = '/run/vzdump.lock';
+my $lockfile = '/run/lock/vzdump.lock';
my $pidfile = '/run/vzdump.pid';
my $logdir = '/var/log/vzdump';
--
2.49.0
--===============6962662411069549652==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============6962662411069549652==--