From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id F12A81FF172
for <inbox@lore.proxmox.com>; Sat, 4 Jan 2025 19:47:56 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id EC6606905;
Sat, 4 Jan 2025 19:47:46 +0100 (CET)
To: pve-devel@lists.proxmox.com
Date: Sat, 4 Jan 2025 19:47:26 +0100
MIME-Version: 1.0
Message-ID: <mailman.80.1736016466.441.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Orwa Diraneyya via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Orwa Diraneyya <info@orwa.tech>, Orwa Diraneyya <diraneyyaorwa@gmail.com>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: [pve-devel] [PATCH container] Fix bug #6040 in the exclusion
pattern of tar
Content-Type: multipart/mixed; boundary="===============4811672272384561395=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
--===============4811672272384561395==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <info@orwa.tech>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id E7345CA658
for <pve-devel@lists.proxmox.com>; Sat, 4 Jan 2025 19:47:45 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id CED726853
for <pve-devel@lists.proxmox.com>; Sat, 4 Jan 2025 19:47:45 +0100 (CET)
Received: from mail-43170.protonmail.ch (mail-43170.protonmail.ch [185.70.43.170])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Sat, 4 Jan 2025 19:47:44 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orwa.tech;
s=protonmail; t=1736016456; x=1736275656;
bh=7EXPW0aYihuTWYHNbIN/UVgC4eIXGCWTNa+C9DnL/J8=;
h=From:To:Cc:Subject:Date:Message-ID:From:To:Cc:Date:Subject:
Reply-To:Feedback-ID:Message-ID:BIMI-Selector:List-Unsubscribe:
List-Unsubscribe-Post;
b=lDB8/QodQald3rr7aXdacIVi3HLvg1jcJkeH1HIeZxPMqo9Zu5ROUdpalCort7dHI
1ouqFLoSYROTgKpXwREQTOrAqKPZiOhce9MENaNnRQtN2V6klHjRJiPWUVYjXZJD6s
VdbCphDYHx1YXToM0ZwH8eE4UqcBhEC4DEgv58fkZY/J8G32Y8VDWl9fEOv7bgvq7O
X72WwolEpvWDORliqmNlIl2do8PaFRFYX7R3YIOasaCB9X0RqAO609lT38HRevyBJ7
beNVB0tzTtBSabwoFHVAIkOvwSSWrNbW1U8LsPq0SUkWsMwpv/BvINLIUZ2yKeSooA
Rska2ww+7OzUw==
X-Pm-Submission-Id: 4YQTvq2jttz4wwl3
From: Orwa Diraneyya <info@orwa.tech>
To: pve-devel@lists.proxmox.com
Cc: Orwa Diraneyya <diraneyyaorwa@gmail.com>
Subject: [PATCH container] Fix bug #6040 in the exclusion pattern of tar
Date: Sat, 4 Jan 2025 19:47:26 +0100
Message-ID: <20250104184726.95658-1-info@orwa.tech>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.001 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain
DMARC_PASS -0.1 DMARC pass policy
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
SPF_HELO_PASS -0.001 SPF: HELO matches SPF record
SPF_PASS -0.001 SPF: sender matches SPF record
From: Orwa Diraneyya <diraneyyaorwa@gmail.com>
After this fix, users of Proxmox will be able to
use the root filesystem tarballs found publicly
(e.g. at https://cloud-images.ubuntu.com/) as LXC
container templates.
Currently, this results in a container-creation
failure due to the root folder `/dev` exclusion
pattern being ineffective.
The bugfix is also announced on the dev mailing
list (mailman.74.1735960093.441.pve-devel)
Signed-off-by: Orwa Diraneyya <diraneyyaorwa@gmail.com>
---
src/PVE/LXC/Create.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm
index 8c8cb9a..4d0d11e 100644
--- a/src/PVE/LXC/Create.pm
+++ b/src/PVE/LXC/Create.pm
@@ -75,7 +75,7 @@ my sub restore_tar_archive_command {
# *sigh*, gnu...
push @$cmd, '--skip-old-files';
push @$cmd, '--anchored';
- push @$cmd, '--exclude' , './dev/*';
+ push @$cmd, '--exclude' , 'dev/*';
if (defined($bwlimit)) {
$cmd = [ ['cstream', '-t', $bwlimit*1024], $cmd ];
--
2.46.0
--===============4811672272384561395==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============4811672272384561395==--