From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BF5C81FF15C for ; Wed, 27 Nov 2024 17:27:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 35DFE1B199; Wed, 27 Nov 2024 17:27:19 +0100 (CET) To: pve-devel@lists.proxmox.com Date: Wed, 27 Nov 2024 17:17:56 +0100 In-Reply-To: <20241127161803.8866-1-lou.lecrivain@wdz.de> References: <20241127161803.8866-1-lou.lecrivain@wdz.de> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Lou Lecrivain via pve-devel Precedence: list Cc: Lou Lecrivain X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] SPAM: [PATCH pve-network 09/16] ipam: nautobot: simplify query Content-Type: multipart/mixed; boundary="===============8042804025601561017==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============8042804025601561017== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AC02ACAEFA for ; Wed, 27 Nov 2024 17:27:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8BF551B155 for ; Wed, 27 Nov 2024 17:27:17 +0100 (CET) Received: from smtp.smtpout.orange.fr (smtp-29.smtpout.orange.fr [80.12.242.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 27 Nov 2024 17:27:17 +0100 (CET) Received: from localhost ([176.139.8.107]) by smtp.orange.fr with ESMTPA id GKkGts0pO9sMcGKkGtaSKI; Wed, 27 Nov 2024 17:18:28 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1732724308; bh=CQHnfTml4kVpHPncGeZAp/4VnTIPYqBnKx4PHBn3Pgk=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=rhYJWwn7ri2ZddolkbIQ+XjF/okdYOcv+AzQdJNoBLzUlun7639rXYT6fLzjF8KeD gUUExn2hcNSoprkt9EXtLwVnRMQHNyxCH5r3F9A7OkXmwuXzO9pgCTkVXTDo45ufxj 3AMNckfRL4B0TSwT46dc768qq0h2I+Z0DXgcO2truzJzTxHyVq7EEC7gSK1u6DxGxl R9MQ8AxjNNqla3lOFdLuoYgoqkObkg33HCufFUb2P24lfpbO2ZfloBUeWLYDbffeg7 utKhKrVuPGCvqgOIKryEWDpZSf3qppCIrDJi8e7keYQtsZvJ8jJu6kEi6ao/JPjX5p 6fwxz8tk4dTmw== X-ME-Helo: localhost X-ME-Auth: bG91LmxlY3JpdmFpbkBvcmFuZ2UuZnI= X-ME-Date: Wed, 27 Nov 2024 17:18:28 +0100 X-ME-IP: 176.139.8.107 From: Lou Lecrivain To: pve-devel@lists.proxmox.com subject: SPAM: [PATCH pve-network 09/16] ipam: nautobot: simplify query Date: Wed, 27 Nov 2024 17:17:56 +0100 Message-Id: <20241127161803.8866-10-lou.lecrivain@wdz.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241127161803.8866-1-lou.lecrivain@wdz.de> References: <20241127161803.8866-1-lou.lecrivain@wdz.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 4 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_REJECT 0.1 DMARC reject policy FREEMAIL_FORGED_FROMDOMAIN 0.001 2nd level domains in From and EnvelopeFrom freemail headers are different FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider HEADER_FROM_DIFFERENT_DOMAINS 0.001 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_REJECT 6 DKIM has Failed or SPF has failed on the message and the domain has a DMARC reject policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust RCVD_IN_MSPIKE_H3 0.001 Good reputation (+3) RCVD_IN_MSPIKE_WL 0.001 Mailspike good senders SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Nautobot can infer object IDs itself Signed-off-by: lou lecrivain --- src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm index 6675ba4..c6581f9 100644 --- a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm +++ b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm @@ -48,10 +48,7 @@ sub add_subnet { #create subnet if (!$internalid) { - my $namespace_id = get_namespace_id($url, $namespace, $headers); - my $status_id = get_status_id($url, default_ip_status(), $headers); - - my $params = { prefix => $cidr, namespace => { id => $namespace_id}, status => { id => $status_id}}; + my $params = { prefix => $cidr, namespace => $namespace, status => default_ip_status()}; eval { my $result = PVE::Network::SDN::api_request("POST", "$url/ipam/prefixes/", $headers, $params); @@ -71,9 +68,6 @@ sub add_ip { my $namespace = $plugin_config->{namespace}; my $headers = ['Content-Type' => "application/json", 'Authorization' => "token $token", 'Accept' => "application/json"]; - my $namespace_id = get_namespace_id($url, $namespace, $headers); - my $status_id = get_status_id($url, default_ip_status(), $headers); - my $description = undef; if ($is_gateway) { $description = 'gateway' @@ -81,7 +75,7 @@ sub add_ip { $description = "mac:$mac"; } - my $params = { address => "$ip/$mask", type => "dhcp", dns_name => $hostname, description => $description, namespace => { id => $namespace_id }, status => { id => $status_id }}; + my $params = { address => "$ip/$mask", type => "dhcp", dns_name => $hostname, description => $description, namespace => $namespace, status => default_ip_status()}; eval { PVE::Network::SDN::api_request("POST", "$url/ipam/ip-addresses/", $headers, $params); -- 2.39.5 --===============8042804025601561017== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============8042804025601561017==--