From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AD7621FF15C for ; Fri, 8 Aug 2025 16:45:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13DAA1B4D2; Fri, 8 Aug 2025 16:46:44 +0200 (CEST) Date: Tue, 05 Aug 2025 20:24:53 +0000 To: "Proxmox VE development discussion" In-Reply-To: References: <06261024c4bd98bf9ab5d8939a110d968c675476@sweetgood.de> X-Mailman-Approved-At: Fri, 08 Aug 2025 16:46:41 +0200 MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: =?utf-8?q?Christian_S=C3=BC=C3=9Fenguth_via_pve-devel?= Precedence: list Cc: =?utf-8?B?Q2hyaXN0aWFuIFPDvMOfZW5ndXRo?= X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] Upstream contribution to ZFSPoolPlugin.pm possible? Content-Type: multipart/mixed; boundary="===============2648070483393010577==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============2648070483393010577== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E9C0AD27ED for ; Tue, 5 Aug 2025 22:24:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BD6651D2D9 for ; Tue, 5 Aug 2025 22:24:56 +0200 (CEST) Received: from mail.sweetgood.de (mail.sweetgood.de [89.58.54.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 5 Aug 2025 22:24:55 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6289F152B13C for ; Tue, 5 Aug 2025 22:24:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sweetgood.de; s=dkim; t=1754425494; h=from:subject:date:message-id:to:mime-version:content-type:in-reply-to: references; bh=OV/oqVrmXgBybboJBApo8moggneFBj91VLMbhj4xOqo=; b=St6F6pJWg7wL4L46Lkf1eHuMXoS30rXH451LInhHGNFDRxlfU40bCFchvxtwoDOsRNbact Xo0Z8W6aeq4RHPJHW6ppLgr48JRwR2G+uYVjgBe4n+Zq7+ryip2EPx1HSho4oZn0NhZJDH 9v5nRwQUkmeAFLlQ22vGwWu83omg3BJ9YsjsstqM9tXXIy4kZMxHSO80mVpWEgy3IBZlWq 7Gb7dsC3JdmVmFMEofbrbNXGR+LAAnkx9X+U1n0KLfjNfUxflpmp04OzLKMIzJl9AZa3W0 eDvPk9x1sZfOnSGzkbA2QtRorq0CmKc3HMPhukie0UIqcX0B9Oz48CyJR74/Mg== MIME-Version: 1.0 Date: Tue, 05 Aug 2025 20:24:53 +0000 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="3134b779-7bc2-49ae-9577-f402d80e9692-2" From: "=?utf-8?B?Q2hyaXN0aWFuIFPDvMOfZW5ndXRo?=" Message-ID: <615f03bf3f7c2b9dfb7572bd1dcffeb42cefb74b@sweetgood.de> Subject: Re: [pve-devel] Upstream contribution to ZFSPoolPlugin.pm possible? To: "Proxmox VE development discussion" In-Reply-To: References: <06261024c4bd98bf9ab5d8939a110d968c675476@sweetgood.de> X-Last-TLS-Session-Version: TLSv1.3 X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy HTML_MESSAGE 0.001 HTML included in message RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sweetgood.de,proxmox.com,zfspoolplugin.pm] X-Mailman-Approved-At: Fri, 08 Aug 2025 16:46:41 +0200 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 --3134b779-7bc2-49ae-9577-f402d80e9692-2 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Max, at first a big thank you for giving me such a detailed answer and also fo= r pointing me to this bugzilla issue. I hope I find time to get through all this and if it's feasible for me to= contribute the way you described i will do. So this is just a quick "thanks" from my side. Will report back as soon a= s there are any updates on this. Thanks, Christian --- Am 5. August 2025 um 16:56 schrieb "Max R. Carrara" : >=20 >=20On Tue Aug 5, 2025 at 3:49 PM CEST, Max R. Carrara wrote: >=20 >=20>=20 >=20> On Tue Aug 5, 2025 at 2:39 PM CEST, =3D?utf-8?B?Q2hyaXN0aWFuIFPDvMO= fZW5ndXRo?=3D wrote: > > Hi Max, > >=20 >=20> sure thing, here's my request without any signature: > >=20 >=20> Dear PROXMOX devs, > >=20 >=20> I have a quick question regarding an upstream contribution to=C2= =A0ZFSPoolPlugin.pm. > >=20 >=20> Currently I'm "maintaining" the following patch which allows migra= tion of encrypted ZFS datasets:=C2=A0https://forum.proxmox.com/threads/al= low-migration-and-replication-of-disks-on-zfs-encrypted-storage.117227/ > >=20 >=20> Ah, interesting! Thanks for sharing. Let me answer your questions = first: > >=20 >=20> What steps would I have to take to have this implemented upstream? > >=20 >=20> In short: > >=20 >=20> 1. Check out the general developer documentation if you haven't > > already: https://pve.proxmox.com/wiki/Developer_Documentation > > 2. You will need to sign a CLA if you haven't yet. For more > > information, see: https://proxmox.com/en/about/open-source/developer= s > > 3. Work on your patch series > > 4. Send the series to this mailing list once you're satisfied > > 5. Wait for feedback / review > > 6. Eventually have your patch series applied once it passes review > > and testing; otherwise goto 3. if changes are requested > >=20 >=20> Of course, depending on the scope and size of the patch series, th= is can > > take a little while, but don't let this discourage you. We always > > welcome contributions and are happy to review and test them! :) > >=20 >=20> Or is there something from dev side which speaks against implement= ing this at all? > >=20 >=20> In general, there's nothing that speaks against implementing this; > > it's rather that it would require some more thorough testing and > > careful planning on how the feature should be integrated overall, as > > storage is something very fundamental in PVE. > >=20 >=20There's another thing I wanted to mention that one of my coworkers > (thanks Aaron!) just pointed out to me: This bug here has been open > since quite a while: > https://bugzilla.proxmox.com/show_bug.cgi?id=3D2350 >=20 >=20Since it has also been referenced in the forum thread you linked abov= e, > I assume you're already aware of it; but anyhow, this issue might be a > blocker in general, unfortunately. I'm not sure if there have been any > recent improvements upstream in that regard. >=20 >=20_______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com mailto:pve-devel@lists.proxmox.com=20 >=20https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > --3134b779-7bc2-49ae-9577-f402d80e9692-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6VH6kdy9okj3lqGAUlM+vNW+ofYFAmiSaJUACgkQUlM+vNW+ ofa7URAAnF26z3Ssx1etx71WWnrHnWtEe7Yey9v8wAXoEPSZRKmQIH95f2y+Y6Bi lLULAQ4THIvlg6FhQ/JIiPGY7x0ucF8064ysIXMuISSsfn3l933eR7R/6NMCLQSZ Wsy4SdE/+RJccmwu6ygIytnjNSRth1kd7RMYqCKUtvmddHaktIYMXn9zI9E7P8m3 RDCuXQJlkeVRg91ROn0uEz4Ok1eAqHGDygOm0iO5ZInLkvnIWkSMzWAqJjfKf+ib jr9ElfBhn4rIvuuHml27ijZQ1zrisp4Kpjvm7P7SWQtu+Y2X77aFXzwthETM+a6p ej8WKQbmgOZ/YHxn8ImQaDp09GCeWnEMfyWJ2AFJDS/NTyzh9uKjMv22NxzSufrZ XtEwEOoUaQqMtxwgY6mr5OTiVUan/qpV1oS0IRg0q4aIhvkKsvifZYmesMp91a2c IP0H7AAvJ72PijF1JI+JVSiu52Di76lb0qhV/JiiGLZDeCKVK3pJ/ImmToqI9xbT ZF3mZ5px+8rp325RROivpCDlS3quE4/W28GAab86Xh1+EwPpRMDX7BAeAJ2wxoQa eaD99i/XZU8PfCYSnw7xmJC9H3bP1eSUZ46ykPTpU7nO7FZZc76g59Yam6UUq3i4 cvs3miRc8KTNHq/Six/groc/y3/PHHLM+nZEBHHAM1f42aR56AY= =EY0S -----END PGP SIGNATURE----- --3134b779-7bc2-49ae-9577-f402d80e9692-2-- --===============2648070483393010577== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============2648070483393010577==--