From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 44D5B1FF161 for ; Tue, 5 Nov 2024 03:01:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B5CA716153; Tue, 5 Nov 2024 03:01:48 +0100 (CET) To: pve-devel@lists.proxmox.com Date: Tue, 5 Nov 2024 15:00:52 +1300 In-Reply-To: <20241105020054.215734-1-severen.redwood@sitehost.co.nz> References: <20241105020054.215734-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Severen Redwood via pve-devel Precedence: list Cc: Severen Redwood , t.lamprecht@proxmox.com X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH qemu-server v3] api: record VM ID as used after a virtual machine is destroyed Content-Type: multipart/mixed; boundary="===============5653181697622310877==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============5653181697622310877== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 99191CA4A6 for ; Tue, 5 Nov 2024 03:01:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 83173160B9 for ; Tue, 5 Nov 2024 03:01:47 +0100 (CET) Received: from mx3.ext.sitehost.co.nz (mx3.ext.sitehost.co.nz [120.138.20.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 5 Nov 2024 03:01:46 +0100 (CET) Received: from localhost (extmx1-new.vps.sitehost.co.nz [127.0.0.1]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTP id D25E6180BA0; Tue, 5 Nov 2024 15:01:28 +1300 (NZDT) X-Virus-Scanned: SiteHost Virus/Spam Prevention on mx3.ext.sitehost.co.nz X-Spam-Flag: NO X-Spam-Score: -3.45 X-Spam-Status: No, score=-3.45 tagged_above=-100 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.55] autolearn=ham autolearn_force=no Received: from mx3.ext.sitehost.co.nz ([127.0.0.1]) by localhost (mx3.ext.sitehost.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UU_rmU9ccd5O; Tue, 5 Nov 2024 15:01:25 +1300 (NZDT) Received: from yggdrasill.. (oep.nct.sitehost.co.nz [120.138.23.30]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTPSA id EF862180C0F; Tue, 5 Nov 2024 15:01:24 +1300 (NZDT) From: Severen Redwood To: pve-devel@lists.proxmox.com Cc: a.lauterer@proxmox.com, t.lamprecht@proxmox.com, Severen Redwood , Daniel Krambrock Subject: [PATCH qemu-server v3] api: record VM ID as used after a virtual machine is destroyed Date: Tue, 5 Nov 2024 15:00:52 +1300 Message-ID: <20241105020054.215734-4-severen.redwood@sitehost.co.nz> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241105020054.215734-1-severen.redwood@sitehost.co.nz> References: <20241105020054.215734-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_PASS -0.1 DMARC pass policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record After a virtual machine is destroyed, record that its ID has been used via the `PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can later optionally avoid suggesting previously used IDs. Co-authored-by: Daniel Krambrock Signed-off-by: Severen Redwood --- Changed since v2 is the addition of the use statement for `PVE::UsedVmidList`. PVE/API2/Qemu.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 848001b6..8759c1e6 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -52,6 +52,7 @@ use PVE::Replication; use PVE::ReplicationState; use PVE::StorageTunnel; use PVE::RESTEnvironment qw(log_warn); +use PVE::UsedVmidList qw(add_vmid); BEGIN { if (!$ENV{PVE_GENERATING_DOCS}) { @@ -2335,7 +2336,9 @@ __PACKAGE__->register_method({ } } - # only now remove the zombie config, else we can have reuse race + # only now mark the VM ID as previously used and remove the + # zombie config, else we can have reuse race + PVE::UsedVmidList::add_vmid($vmid); PVE::QemuConfig->destroy_config($vmid); }); }; -- 2.47.0 --===============5653181697622310877== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============5653181697622310877==--