From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4F2241FF164 for ; Fri, 6 Dec 2024 11:33:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C974F297D; Fri, 6 Dec 2024 11:33:16 +0100 (CET) To: , Date: Fri, 6 Dec 2024 10:33:12 +0000 References: <20241128170942.4717-1-lou.lecrivain@wdz.de> <36f10b54-4360-4aad-86de-23a8d37c5815@proxmox.com> In-Reply-To: <36f10b54-4360-4aad-86de-23a8d37c5815@proxmox.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Lou Lecrivain via pve-devel Precedence: list Cc: Lou.Lecrivain@wdz.de X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist Content-Type: multipart/mixed; boundary="===============4080908761525541394==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============4080908761525541394== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 67BE2C0FDD for ; Fri, 6 Dec 2024 11:33:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48DAD2947 for ; Fri, 6 Dec 2024 11:33:15 +0100 (CET) Received: from mail2.lsw.de (mail2.lsw.de [62.176.232.134]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 6 Dec 2024 11:33:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdz.de; i=@wdz.de; q=dns/txt; s=wdz201805; t=1733481194; x=1765017194; h=from:to:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=NVxzhyziGbowOFqV8iYPXOSQAG+TmRoSEwvtJW6Kd7Y=; b=sRFQp4zzz6873LbFa1rzKGGMgslSa1slSwR7UNeXxbH1XrkJ2i8J8Rz6 9MtAMtdm90Yr0bZIoj357ZQ2KX3RXYMwPLZraaPfbrZcr3VzpWtFpqsB4 CdfZvoJlN1ES9AweW9yIZ+EW4PfOuM1t+UAEfqEDwh2skmtjW++0RU8Yl 4hQ2kUMyg9Lh5S67+Qp+SvVF3UoBfh9h7S89sVXiC9J5L+HgS0+4VWAHx AyR06i0foxoKAeAd+H5C5VUMEfySaJH9aSZ4FyZP3NhtzJegEz8nSPLQ6 WeovgYdFQrIejamkSiBba8+VoqkUee9pdLFqXOdz6G6SUbTRhCatHyLzu w==; X-CSE-ConnectionGUID: OlhD1EhxS+CJdSx7h/2vlQ== X-CSE-MsgGUID: cW6NE3xGStWSgbFfVJ8atQ== X-IronPort-AV: E=Sophos;i="6.12,213,1728943200"; d="scan'208";a="20197965" Subject: RE: Re: [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist Received: from internalmail by mail1.lsw.de; 06 Dec 2024 11:33:14 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kp2UTrefYQ3ohCKCtDbN2Ij7NqaAEpm3EKZcgF37QV98OMvGm5TuZuQcZXXVugaS70gQHVt4KeKVLH7/BM9bR3N5xZxgMtt/f7tE+nI1heipgxyDk6FSGxsKFwGjR2nhVOVSVEUj1oBveEPSg8BDdQNvXBtPdsWokuy37fg5rgrrUec43SfrVwsJuuJAnNc3mvjAkd9QfAhZFyB6dHoy2Lb910PDROKgvwPuvkl6bw26GReO02teWmy6DyMvsVAn6SgJP6WL0GhxaVG2gLoeOR4hfrXIF/iOqguvc5le9c9IUPjIiEqVA+7gN7Fqhu+FUpLgbCA7NvUD6J6sz51y6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NVxzhyziGbowOFqV8iYPXOSQAG+TmRoSEwvtJW6Kd7Y=; b=ElokC60Pfzq95JfQyU4gZGsMSbjmvjjiG37uNv4792Upj+GjCfmNOa7czTh3Ruq4N/DtvH7EIH5u2XVckOBD3Foj/EVV9ENGngT4543+xw6v4hDtUWBprpAmymYBTh2uBM4VLM5ECdoB9Mj3Vh3ehk8iTrhGoGGuGwJpQAkwPFme9L9evvVYbOdJkQbNE0jcK7/g4LAKIXvljEQOjJ7AKGGvue/ZspGxzCZMXl09yQAOPNp9kWkxBn8FDfSyh2X4nJI8r3ojdHzsAWgEv5nTZxebb+wogq8Stb52muEwc2gX8DX38QLDW3b2E77EZ7Ye00v4zy3ZAReRleaJYSy4fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdz.de; dmarc=pass action=none header.from=wdz.de; dkim=pass header.d=wdz.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lswnetz.onmicrosoft.com; s=selector1-lswnetz-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NVxzhyziGbowOFqV8iYPXOSQAG+TmRoSEwvtJW6Kd7Y=; b=IM+KbSvfEqO3rsOP8BF9MUIqFQyrigp/CQsygAudsxQorCyJ3PiJg5Pfi1MCAznR+TZPuzojPlRI8tgLrplELplskGxE4AhcWMKAxENZ+F7VWAcnl9EUjigLLRw+oYcbuCerq3+MQjMzfEAGC1tN7BOXO+YWPIza/qE8zSDgTBI= From: To: , Thread-Topic: [!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist Thread-Index: AQHbRzGOEYjfBdpeL0qqoSc2bp832rLZBWqj Date: Fri, 6 Dec 2024 10:33:12 +0000 Message-ID: References: <20241128170942.4717-1-lou.lecrivain@wdz.de> <36f10b54-4360-4aad-86de-23a8d37c5815@proxmox.com> In-Reply-To: <36f10b54-4360-4aad-86de-23a8d37c5815@proxmox.com> Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wdz.de; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BE1P281MB2116:EE_|FR6P281MB4061:EE_ x-ms-office365-filtering-correlation-id: fb00b8e8-7983-4d97-fc5a-08dd15e162e2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|10070799003|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?ORJ6b8Tt8X0iVsARrl86xmPDlTWcc7dheY5NCazeAd1c3YpOgOs0Eu62Uu?= =?iso-8859-1?Q?MfMljw7TQmrOmbMfz63utK2xfakrzYzGVGGvApUbylYqH2A8fJv/TkFdU7?= =?iso-8859-1?Q?jalc5vUT4xPWuazwO6UpzW83vQwXJzlfVQdbgZxF9N9v7jAms3daEO7S1m?= =?iso-8859-1?Q?cZ+gKXDvcq8EHd38YVk5BSw1hUObHzDYrR0Pqc/CX3TqYZEQDLU3zHcAsP?= =?iso-8859-1?Q?iBxRPBYnIHDLauYn+A9YC95Qy7ObK85hdBrR7HNyUpKraij8x/xkCLRc1t?= =?iso-8859-1?Q?ZkcFINoDcTssMG7e8T9cseJqRvGAl26+Z49WZO0YCOG3/q6rjrglwLLjiY?= =?iso-8859-1?Q?vGYgG8ZQQFvqMkGwtV3izrmZPzkASMqtrIY1bRyua1koWqtZDXVVw1XoAG?= =?iso-8859-1?Q?Z90AU97J1BzhUM6ACzmWUBwux7SmvEjV+yv+aE9VrTVZHgxtBG8G+/zWvz?= =?iso-8859-1?Q?FhdRg4vSUWkmMesJF3atXCyRARFyhhaz7Wt2m72z02m+KibocU5xudt+O4?= =?iso-8859-1?Q?z0PHHm0ONTKi6V5coqYAAQ1bF6+wzuXyfVN+GTYnW4p2OxfLqo3+c+ko0a?= =?iso-8859-1?Q?UsZ+pS7perWCF3zIfV11j10J8dDu/yF2RP5NCwKC6vHH4KegeTFRqGEhSf?= =?iso-8859-1?Q?4YQnMav4L9F3xNx8iaNNZ9TiJOUIwJu1nDugtiBE0+PraStRt3s1cy/yPo?= =?iso-8859-1?Q?ZZVrtYEyMOQky5nmyUTstQ76MgBBgWAvwCCGDbXMU+LvDGLHzDX+o5u9Ib?= =?iso-8859-1?Q?t3JtogJZwmfdrkxUuqZn5GisAFEp/ffxIaGAEKBiNslyrceWVCCT1a3Vsa?= =?iso-8859-1?Q?mmyY6kYaJgMMtdD4cJuS+Swhcj8cmPyyTbgNeBRjBYzJQUxDltsmjD5aeL?= =?iso-8859-1?Q?n/s06cAdM53ptJmkhbjUiGvZ4NdnYrNS7nuK51Z0oQo+N/nPZLlKgPNdCI?= =?iso-8859-1?Q?NMqZHJI79jQLMEMnT98pDC2fwg1udPWFMrOGl2KN/cPX0h/cji9EFjCp1P?= =?iso-8859-1?Q?6oIjcGOCyjFqX+wevH9qmU+nGbVbzouyIhPH/TaFHP+QXsVt8eFvg/BVTa?= =?iso-8859-1?Q?nQ/0/IYtBSKiy2AYPGUsGNbIvi4JazPjJLYfHZsqAEoP+FOYPRsJTJ/WFm?= =?iso-8859-1?Q?FDP2zaMi3goISDP8JPjXGWoo7BCuZMYpiyeIGOAwlLAOBxKNoVNiBACLfF?= =?iso-8859-1?Q?YRA5Z6Z1k5fqC9f1bf3mQuuP0XsivUo+wCnnbw/8okz25en4o5g0/CmnXD?= =?iso-8859-1?Q?68d0M4uqru8izEt7N3a6usQKOpQfUjdeAkdvM3UgTyflvqyWWYcdP97FMd?= =?iso-8859-1?Q?FC7YqlAKJSO2CZWnDufThBKMzBoTVpQnWyscxtkfbs9jrGly7/gcbl3f1U?= =?iso-8859-1?Q?NA7gfHNvuqAV5qOYgQeRV6Qlkdsgr+wCw/ehJWGX3LALrUUPXAbnkKZbko?= =?iso-8859-1?Q?8SryRaxNH0jMcQITL2Je3mToI2svvkBXcAkRgw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BE1P281MB2116.DEUP281.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(10070799003)(1800799024)(366016)(38070700018);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ho6VeYI4kkDzka+arQYey/dVvOaiQFn/zwou2M/Wgzn3UUjw6MlRuaLGz+?= =?iso-8859-1?Q?eXzaYil0in1EXedC8WIfg/+5SC+b+ja+TByd2jd6/Zw/hnppY3E+5Hve9Q?= =?iso-8859-1?Q?PlM+rnF4dqesFjEUdiXICxeAkK921XT3pMdR4KRl6hayhSB1a+ooJ/H6RY?= =?iso-8859-1?Q?9QuuMkU6MrPUIbsViJYKerVkSyipwB8yMEqKqSloPgbktMBQ4eQ+VfinOF?= =?iso-8859-1?Q?o72klTxrdjPu0qFJJJlo0sI+gxFgeKDRAI1LXUdqWszz7Afq41NaP9dQUF?= =?iso-8859-1?Q?U5JbhpuGbLxZdEQn7j4Hi0M23S4ks5v+0OAJwI/yj0SX7yrf+o+Xcpg6kg?= =?iso-8859-1?Q?YSXSc9GJFmRGbSqneERK9kQW/Fgc35g8oi9vYZekCzGJ6+OuHiL1hKye0G?= =?iso-8859-1?Q?GYCnCi3QrYBd+7Lk8qaVtxd8I1IJ4V4yR9AyDPW0jTdT8Z4j72oXiFcfmq?= =?iso-8859-1?Q?+3GyRXcPMjWD7QVmJsGuah4GeU7T5fV0yLz/caeQTmI/vzp69eaB0cCAiQ?= =?iso-8859-1?Q?PfkdJ7PBUDElcShSa05B999YgrxI6u0uECuaLzN025vuXiL1y8b0tufvPr?= =?iso-8859-1?Q?zRDtxrz7X32QtjxyMRQa8RuO6Squ4Xe/1d0ieGYlk/9ajpJuNcAaPSdRVt?= =?iso-8859-1?Q?3T5NnxaidKJsVd+Ql8HWz983o2f+NzkWF0BIO2P/1qxCtQ9S4AFb8Wn2Y4?= =?iso-8859-1?Q?jPinMklQbpMLWxiz5N1k9+3SvTzz6d0cuFTcxsFLkgqsuCoMc++1BUEBYZ?= =?iso-8859-1?Q?SIIU+tM93lx4g0/S6anjJQh7WdcChFeePSZE4Duu1FOP+AtVRbYmdxvJwg?= =?iso-8859-1?Q?qXa5SL7HYb2zKL2dEVpjM2+ETZ0UBNGk1Ed6FjbKwxnHIoxDdbp8tdEfpO?= =?iso-8859-1?Q?MtE+18jdQs1cww/4sMDMy7Y9YnMb0wk4HSjGZ0aKa02jNeSwfwvzI2gKM/?= =?iso-8859-1?Q?7lflYUjku4V2R97OiAzKWKMPhumw4OzIU7TFpyRUfRE4IY9MfawTTPtGF/?= =?iso-8859-1?Q?r46ID6Dp43tBYkxitueWdHqu/8PwaGHF6i17qgOiGLxs+POX75JnbRFY3l?= =?iso-8859-1?Q?d+OhywnoWO2Oc1lZDac0rpWITaNFRrw28d2YqNXFd7R2JXxxy5C+phx4nt?= =?iso-8859-1?Q?90/LNZSyjgrX+nF9gznvU9nd3yKqLFi5OwHx0OmFWn5GRftzIpkkHBC0hB?= =?iso-8859-1?Q?1IdM+Ez7by2HAcRSxCqN0QV0q6GJJg8mzDLQqZX0bmW1Ue1REdP45VAc4z?= =?iso-8859-1?Q?VFQcqiyt8G5LLrT5p0qj3IFMLhvlxscB7ULX2F3Ux/RFLUEB6HyQXITXOn?= =?iso-8859-1?Q?Mu+a7IouHrAGSiiSTNL6FX0FpOR+ePgcHmcnqYdJH0k6g4jvkz6s264Jgj?= =?iso-8859-1?Q?932KGvvDkx7mQgj2az850Dm5O0z8IZA0AqAzhhxrqdAuR6VrmZ35CfcU+0?= =?iso-8859-1?Q?cURumVROfPIhs2BrayML6TLIoxRTfqbeMgKNWMZyrq959bd42zB7dcpO/e?= =?iso-8859-1?Q?7G918RI1no0eIaG7fyd4YrAMA6bZfNhsYUiyEeaB2ivcOMis9XBDY/oP0q?= =?iso-8859-1?Q?08qECdU0b6zRsWOZeJYg8uo86bADe+/A7wD8t2Y7klAcRppMRvgxBI9Dgc?= =?iso-8859-1?Q?1YVZi3I62S+ANyLioLkTL/E3o7hCCJTBS+hiXHhGFXhWIeSRQm8ud3ZpdV?= =?iso-8859-1?Q?izA3mp9g1TngMoG6Oxk=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BE1P281MB2116.DEUP281.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: fb00b8e8-7983-4d97-fc5a-08dd15e162e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2024 10:33:12.7320 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d1b757c4-c391-4d47-b0de-c8365891bd6b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y8nnGAAGAphndTkSodInY8skQsRP3X6no+WeUR35Q8ZLd+Nr1Ma+Sds/7bSrlO+kvSFoeApcotT4SfR3pyzzdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR6P281MB4061 X-OriginatorOrg: wdz.de X-C2ProcessedOrg: 146dacec-6c92-4c17-8986-3fcc31a486b0 X-SPAM-LEVEL: Spam detection results: 0 ARC_SIGNED 0.001 Message has a ARC signature ARC_VALID 0.001 Message has a valid ARC signature AWL -1.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lswnetz.onmicrosoft.com,wdz.de] Re,=0A= =0A= Seems like I did not test this enough, whoops.=0A= =0A= > Maybe it would make sense to move the whole code of configure_range to=0A= > configure_subnet in the Dnsmasq plugin, since the whole subnet gets=0A= > configured anyway and make configure_range a noop?=0A= Yes, do agree on this one. I think it'd be cleaner in terms of code.=0A= =0A= I'll take this into account for next version. Thanks.=0A= =0A= BR=0A= ________________________________________=0A= De :=A0Stefan Hanreich =0A= Envoy=E9 :=A0jeudi 5 d=E9cembre 2024 17:20=0A= =C0 :=A0Proxmox VE development discussion =0A= Cc=A0:=A0Lecrivain, Lou (WDZ) =0A= Objet :=A0[!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network 2= /2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist=0A= =A0=0A= Seems like this still is a remnant from when we used to configure the=0A= ranges explicitly dhcp-range. But adding two DHCP ranges just generates=0A= two identical lines in the dnsmasq config:=0A= =0A= > dhcp-range=3Dset:public-172.20.44.0-24,172.20.44.0,static,255.255.255.0,i= nfinite=0A= > dhcp-range=3Dset:public-172.20.44.0-24,172.20.44.0,static,255.255.255.0,i= nfinite=0A= =0A= Maybe it would make sense to move the whole code of configure_range to=0A= configure_subnet in the Dnsmasq plugin, since the whole subnet gets=0A= configured anyway and make configure_range a noop?=0A= --===============4080908761525541394== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============4080908761525541394==--