From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 26CD81FF166 for ; Fri, 8 Nov 2024 02:47:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 30A3639C47; Fri, 8 Nov 2024 02:47:18 +0100 (CET) To: pve-devel@lists.proxmox.com Date: Fri, 8 Nov 2024 14:46:18 +1300 In-Reply-To: <20241108014620.73352-1-severen.redwood@sitehost.co.nz> References: <20241108014620.73352-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Severen Redwood via pve-devel Precedence: list Cc: Severen Redwood , t.lamprecht@proxmox.com X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH cluster v4 2/2] datacenter config: add unique-next-id to schema Content-Type: multipart/mixed; boundary="===============0027418373303552729==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============0027418373303552729== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9FF13C10BE for ; Fri, 8 Nov 2024 02:47:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 81EAA39B26 for ; Fri, 8 Nov 2024 02:46:46 +0100 (CET) Received: from mx3.ext.sitehost.co.nz (mx3.ext.sitehost.co.nz [120.138.20.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 8 Nov 2024 02:46:45 +0100 (CET) Received: from localhost (extmx1-new.vps.sitehost.co.nz [127.0.0.1]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTP id 74D93180B23; Fri, 8 Nov 2024 14:46:37 +1300 (NZDT) X-Virus-Scanned: SiteHost Virus/Spam Prevention on mx3.ext.sitehost.co.nz X-Spam-Flag: NO X-Spam-Score: -3.449 X-Spam-Status: No, score=-3.449 tagged_above=-100 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.55, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx3.ext.sitehost.co.nz ([127.0.0.1]) by localhost (mx3.ext.sitehost.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c1Bs2y3qxRrc; Fri, 8 Nov 2024 14:46:33 +1300 (NZDT) Received: from yggdrasill.. (oep.nct.sitehost.co.nz [120.138.23.30]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTPSA id 7E524180BA1; Fri, 8 Nov 2024 14:46:33 +1300 (NZDT) From: Severen Redwood To: pve-devel@lists.proxmox.com Cc: a.lauterer@proxmox.com, t.lamprecht@proxmox.com, Severen Redwood , Daniel Krambrock Subject: [PATCH cluster v4 2/2] datacenter config: add unique-next-id to schema Date: Fri, 8 Nov 2024 14:46:18 +1300 Message-ID: <20241108014620.73352-4-severen.redwood@sitehost.co.nz> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241108014620.73352-1-severen.redwood@sitehost.co.nz> References: <20241108014620.73352-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_PASS -0.1 DMARC pass policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Add the `unique-next-id` property to the datacentre config schema to track whether only unique (ie. neither currently nor previously in use) VM/CT IDs should be suggested by the `/cluster/nextid` API endpoint. Co-authored-by: Daniel Krambrock Signed-off-by: Severen Redwood Tested-by: Aaron Lauterer Reviewed-by: Aaron Lauterer --- There are no changes to this patch since v3. src/PVE/DataCenterConfig.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm index abd0bbf..d1d4533 100644 --- a/src/PVE/DataCenterConfig.pm +++ b/src/PVE/DataCenterConfig.pm @@ -337,6 +337,11 @@ my $datacenter_schema = { format => $next_id_format, description => "Control the range for the free VMID auto-selection pool.", }, + 'unique-next-id' => { + optional => 1, + type => 'boolean', + description => "Only suggest VMIDs that are neither currently in use nor have previously been used.", + }, migration => { optional => 1, type => 'string', format => $migration_format, -- 2.47.0 --===============0027418373303552729== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============0027418373303552729==--