From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3C09A1FF166 for ; Fri, 8 Nov 2024 02:47:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA2C639C21; Fri, 8 Nov 2024 02:47:12 +0100 (CET) To: pve-devel@lists.proxmox.com Date: Fri, 8 Nov 2024 14:46:20 +1300 In-Reply-To: <20241108014620.73352-1-severen.redwood@sitehost.co.nz> References: <20241108014620.73352-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Severen Redwood via pve-devel Precedence: list Cc: Severen Redwood , t.lamprecht@proxmox.com X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH container v4] api: record CT ID as used after a container is destroyed Content-Type: multipart/mixed; boundary="===============7895146611685178206==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============7895146611685178206== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1A028C10AB for ; Fri, 8 Nov 2024 02:47:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3B63E39AFD for ; Fri, 8 Nov 2024 02:47:07 +0100 (CET) Received: from mx3.ext.sitehost.co.nz (mx3.ext.sitehost.co.nz [120.138.20.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 8 Nov 2024 02:47:06 +0100 (CET) Received: from localhost (extmx1-new.vps.sitehost.co.nz [127.0.0.1]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTP id 63696180B80; Fri, 8 Nov 2024 14:46:41 +1300 (NZDT) X-Virus-Scanned: SiteHost Virus/Spam Prevention on mx3.ext.sitehost.co.nz X-Spam-Flag: NO X-Spam-Score: -3.449 X-Spam-Status: No, score=-3.449 tagged_above=-100 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.55, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx3.ext.sitehost.co.nz ([127.0.0.1]) by localhost (mx3.ext.sitehost.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E4hxMNul4iXq; Fri, 8 Nov 2024 14:46:37 +1300 (NZDT) Received: from yggdrasill.. (oep.nct.sitehost.co.nz [120.138.23.30]) by mx3.ext.sitehost.co.nz (Postfix) with ESMTPSA id 91FF5180BC9; Fri, 8 Nov 2024 14:46:33 +1300 (NZDT) From: Severen Redwood To: pve-devel@lists.proxmox.com Cc: a.lauterer@proxmox.com, t.lamprecht@proxmox.com, Severen Redwood , Daniel Krambrock Subject: [PATCH container v4] api: record CT ID as used after a container is destroyed Date: Fri, 8 Nov 2024 14:46:20 +1300 Message-ID: <20241108014620.73352-6-severen.redwood@sitehost.co.nz> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241108014620.73352-1-severen.redwood@sitehost.co.nz> References: <20241108014620.73352-1-severen.redwood@sitehost.co.nz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_PASS -0.1 DMARC pass policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record After a container is destroyed, record that its ID has been used via the `PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can later optionally avoid suggesting previously used IDs. Co-authored-by: Daniel Krambrock Signed-off-by: Severen Redwood Tested-by: Aaron Lauterer Reviewed-by: Aaron Lauterer --- Changed since v3 is removing an unnecessary `qw(add_vmid)` after `use PVE::UsedVmidList`. src/PVE/API2/LXC.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 213e518..e35b26d 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -28,6 +28,7 @@ use PVE::API2::LXC::Config; use PVE::API2::LXC::Status; use PVE::API2::LXC::Snapshot; use PVE::JSONSchema qw(get_standard_option); +use PVE::UsedVmidList; use base qw(PVE::RESTHandler); BEGIN { @@ -794,7 +795,9 @@ __PACKAGE__->register_method({ } } - # only now remove the zombie config, else we can have reuse race + # only now mark the CT ID as previously used and remove the zombie + # config, else we can have reuse race + PVE::UsedVmidList::add_vmid($vmid); PVE::LXC::Config->destroy_config($vmid); }; -- 2.47.0 --===============7895146611685178206== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============7895146611685178206==--