From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 6F7D11FF17A
	for <inbox@lore.proxmox.com>; Sat, 23 Nov 2024 07:13:43 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 542521D40E;
	Sat, 23 Nov 2024 07:13:51 +0100 (CET)
To: pve-devel@lists.proxmox.com
Date: Sat, 23 Nov 2024 15:10:05 +0900
In-Reply-To: <20241122110243.1426459-1-jing@jing.rocks>
References: <20241122110243.1426459-1-jing@jing.rocks>
MIME-Version: 1.0
Message-ID: <mailman.599.1732342430.391.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Jing Luo via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Jing Luo <jing@jing.rocks>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: [pve-devel] [PATCH pve-network v2] d/control: break the circular
 build-dependency with pve-firewall, and more
Content-Type: multipart/mixed; boundary="===============8435667875066656952=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

--===============8435667875066656952==
Content-Type: message/rfc822
Content-Disposition: inline

Return-Path: <jing@jing.rocks>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by lists.proxmox.com (Postfix) with ESMTPS id 25BB0C8F10
	for <pve-devel@lists.proxmox.com>; Sat, 23 Nov 2024 07:13:50 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 066751D3A5
	for <pve-devel@lists.proxmox.com>; Sat, 23 Nov 2024 07:13:50 +0100 (CET)
Received: from mail-gw3.jing.rocks (mail-gw3.jing.rocks [219.117.250.209])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by firstgate.proxmox.com (Proxmox) with ESMTPS
	for <pve-devel@lists.proxmox.com>; Sat, 23 Nov 2024 07:13:49 +0100 (CET)
Received: from mail-gw3.jing.rocks (localhost [127.0.0.1])
	by mail-gw3.jing.rocks (Proxmox) with ESMTP id 50E2A21745
	for <pve-devel@lists.proxmox.com>; Sat, 23 Nov 2024 15:13:46 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jing.rocks; h=cc
	:cc:content-transfer-encoding:date:from:from:in-reply-to
	:message-id:mime-version:references:reply-to:subject:subject:to
	:to; s=mail-gw; bh=22x9PsUUkDfflSTxN3AG1+IMnghIJuOh0JvN4yZdzCs=; b=
	oaAIAo3Dk2w39e32mEFRfmY76N6uJu+G3ctWshi/6z6W2oY25qtCkXoUGQmpNEa8
	nHRMANxpVI9oZXuh1XLEoH6lmJ8dod7jUrUTc9oAEbPaSHX6+9A3SHhwUHw9rgyT
	87BS0akPAJGBFgMr8bRotwjObmTRFSf1+vHfZ8GvAkyAyTvrq+2Ih5X8cyWoLi2Y
	6Kh+wOpEp9rLNivaJiufX45bSqUBaXDMifSQKT7kgLGg75X1tBZLU5eX2frAoqFT
	RdjwIp6wX9LvMJUJ4BOfQS4sP6j9q43FmBPqipZmwf33CfdwgNtANwR3znadqmDO
	A2uTnhYUMxF5Ka/1fxfOUA==
Received: from mail.jing.rocks (mail.jing.rocks [IPv6:240b:10:f00:1b00::222])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by mail-gw3.jing.rocks (Proxmox) with ESMTPS id 2224521744
	for <pve-devel@lists.proxmox.com>; Sat, 23 Nov 2024 15:13:45 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jing.rocks;
	s=default; t=1732342425;
	bh=mtK6uEy4QDij6iQAEFyFzigxw5ANIhSEKtkpGCTSzPo=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=NwQ4sIJX01RdHquAbqvj97bMW3x/pL/Dd9lDxsug7/Zt5wG/zcghIapOz4wnLI2WK
	 6t5mu7V9+rnNdqL71pfGPeUsRJLQrKcG6WAXxnZboeY4RQZFgMNHRNOgG3Bnu5QOGc
	 Io757Ne0Ndtef07es9cXJkDh/6rG+8fNuGdz7cvlmiuyDxFatV/XlTaSGjc6AIaQlv
	 FMdT04obp7A5dv2ieu3SyA0SAk4OGcrhAqS+1DBoYyX87Dc1r6PgBbNmT0VMCMBp0K
	 IzPod1qebaXYZXA2WNgqj1Fxmud7zKZWA2wUaRVbLRBhpaZdCKqqkzFEDoX/qAMJfh
	 vs51CpmQi+V5g==
Received: from X570AM.jing.rocks (X570AM.jing.rocks [IPv6:240b:10:f00:1b00::7e82])
	(Authenticated sender: jing@jing.rocks)
	by mail.jing.rocks (Postfix) with ESMTPSA id 15C403D1FA;
	Sat, 23 Nov 2024 15:13:45 +0900 (JST)
From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-network v2] d/control: break the circular build-dependency with pve-firewall, and more
Date: Sat, 23 Nov 2024 15:10:05 +0900
Message-ID: <20241123061327.1640019-1-jing@jing.rocks>
X-Mailer: git-send-email 2.47.0
In-Reply-To: <20241122110243.1426459-1-jing@jing.rocks>
References: <20241122110243.1426459-1-jing@jing.rocks>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DKIM_SIGNED               0.1 Message has a DKIM or DK signature, not necessarily valid
	DKIM_VALID               -0.1 Message has at least one valid DKIM or DK signature
	DKIM_VALID_AU            -0.1 Message has a valid DKIM or DK signature from author's domain
	DKIM_VALID_EF            -0.1 Message has a valid DKIM or DK signature from envelope-from domain
	DMARC_PASS               -0.1 DMARC pass policy
	KAM_INFOUSMEBIZ          0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware
	KAM_OTHER_BAD_TLD        0.75 Other untrustworthy TLDs
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked.  See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked.  See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked.  See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
	URIBL_BLOCKED           0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked.  See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [jing.rocks,proxmox.com]

Currently pve-network has a (versioned) build-dep of pve-firewall, which has
a (versioned) runtime dependency of a newer version of libpve-network-perl,
which is not available because it has not been built. It turns out that
pve-firewall is only needed in testing, so let's only pull it in if
we don't use the "nocheck" build profile so that we can actually build
pve-network from source.

perl is a build-essential so no need to add it in build-deps.

Fixes: cbc70c81b9a2647a20903b27cabb14c1d6dc6d76
Signed-off-by: Jing Luo <jing@jing.rocks>
---
Changes since v1:
 - remove perl from build-dep because it's an essential package
 - all the perl libs are only needed in testing, so adding <!nocheck> to them
---
 debian/control | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/debian/control b/debian/control
index bb8cef9..a168c56 100644
--- a/debian/control
+++ b/debian/control
@@ -4,14 +4,13 @@ Priority: optional
 Maintainer: Proxmox Support Team <support@proxmox.com>
 Build-Depends: debhelper-compat (= 13),
                lintian,
-               libfile-slurp-perl,
-               libnet-subnet-perl,
-               libtest-mockmodule-perl,
-               perl,
-               pve-cluster (>= 8.0.10),
-               pve-firewall (>= 5.1.0~),
-               pve-doc-generator (>= 5.3-3),
-               libpve-access-control,
+               libfile-slurp-perl <!nocheck>,
+               libnet-subnet-perl <!nocheck>,
+               libtest-mockmodule-perl <!nocheck>,
+               pve-cluster (>= 8.0.10) <!nocheck>,
+               pve-firewall (>= 5.1.0~) <!nocheck>,
+               pve-doc-generator (>= 5.3-3) <!nocheck>,
+               libpve-access-control <!nocheck>,
 Standards-Version: 4.6.1
 Homepage: https://www.proxmox.com
 
-- 
2.47.0




--===============8435667875066656952==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

--===============8435667875066656952==--