From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CBB0E1FF161 for ; Wed, 20 Nov 2024 17:58:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A3C9152D1; Wed, 20 Nov 2024 17:58:36 +0100 (CET) References: <20241115151749.633407-1-d.csapak@proxmox.com> <6efce1fc-0e03-4966-ac3a-ee433f2acc01@proxmox.com> <21c1cac9-3e70-4b37-9767-d5cc160c9ca9@proxmox.com> <039ab04f-48e2-4285-91c3-ffe95ee372b9@proxmox.com> <1c8f245c-ac98-4633-9c10-69e6a7dd7b2a@proxmox.com> In-Reply-To: Date: Wed, 20 Nov 2024 13:57:18 -0300 To: Proxmox VE development discussion MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Gilberto Ferreira via pve-devel Precedence: list Cc: Gilberto Ferreira , Lukas Wagner X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages Content-Type: multipart/mixed; boundary="===============0689681968782094833==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============0689681968782094833== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3DBA9C7B83 for ; Wed, 20 Nov 2024 17:58:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16FFA152E6 for ; Wed, 20 Nov 2024 17:58:05 +0100 (CET) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 20 Nov 2024 17:58:03 +0100 (CET) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-539f1292a9bso2885573e87.2 for ; Wed, 20 Nov 2024 08:58:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732121876; x=1732726676; darn=lists.proxmox.com; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f0cBA4/5pGqD9smeG4v2D8X7hubmj8M2USBbnUGDmQo=; b=EJsisrlYwG4WY1DBtcE8seAgnnsR4zdNPNnx+lnpOawVdzM4cc07f0B7CcIi1/rQPe MpOW5Y04pCS1jMzu4Y+g+Yiy7rKpT3H5gWiP8vz996fBEz64YqJ2R21jrwpunv/oiHY2 31Gxdmq/vsc5ckh5G+N8IS18tDZAyCmA+u3fLGg3oAMp2jqx1HGIXzSBQMSoWYeDFG/d msdtUL4c5RicqmTSWYULVb7zeaSSlnZ4sIQfDHlQaie6x11+geMqPtvOLPZr/gP05aBx yOz2x749BE8CJdOPwWnyKtOuhTuXNi8dM4PEWTlM/ntrAZPdYSpXPms5MSv+PD/8MWfs x8Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732121876; x=1732726676; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f0cBA4/5pGqD9smeG4v2D8X7hubmj8M2USBbnUGDmQo=; b=CQqgWcZue1XOPt5EZIlAzxjl94HSK+KVMwaInDxbUPOuSAY95SEU07c5MOjTw4DwdV 5ur7636s7IkbTYTwiPhaA3Nj3u4ed/cS5CV4Uhn6zbAla6J+bTO/WG83rrcSpFapWJxu H7b1YKw61xK5ZBPLKhhNgiQzYtu581ta2JIANKldQcbSAiY6p16FBhBbiF+QKmgfp8bi ACWAPDK3tCyDzjF9N792MsDn03tk0arqm3Hy/YPK60Y5MfSVRKf5CzBn677mfHtxC/06 EP2hPxms4VKr4zvN/bznTi7pzf7/iFjJ3A+lH/zhasXYF5nq0qRPkneW1qxqyTvx4Nv5 /XXQ== X-Gm-Message-State: AOJu0Ywm53hJZ20DhPqn0tRbBm1i6s4KCxcZhMBRDAh7YFvP6x44v+lG xixxfnGH1zY14BGkEGquEGoa795rtVf4xg5ixxfVJ++MH/qUjpOSAHM6604BgtSIr+d1yONMQiT OC0G/QI1XClag/9X6Gzti9c0n+nsrHr5S29Q= X-Google-Smtp-Source: AGHT+IGmjagbRyPaVwMHy3ot1CQZddvQ4Xf39du8qfZ4dpzU8rL5ZWqdMV84IkxulhuCD3clVlIOUzCgPgMn+77YBng= X-Received: by 2002:a19:e04c:0:b0:53d:a550:bdf3 with SMTP id 2adb3069b0e04-53dc13338c0mr1140503e87.23.1732121875590; Wed, 20 Nov 2024 08:57:55 -0800 (PST) MIME-Version: 1.0 References: <20241115151749.633407-1-d.csapak@proxmox.com> <6efce1fc-0e03-4966-ac3a-ee433f2acc01@proxmox.com> <21c1cac9-3e70-4b37-9767-d5cc160c9ca9@proxmox.com> <039ab04f-48e2-4285-91c3-ffe95ee372b9@proxmox.com> <1c8f245c-ac98-4633-9c10-69e6a7dd7b2a@proxmox.com> In-Reply-To: From: Gilberto Ferreira Date: Wed, 20 Nov 2024 13:57:18 -0300 Message-ID: Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages To: Proxmox VE development discussion Cc: Lukas Wagner X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 0.25 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider HTML_MESSAGE 0.001 HTML included in message POISEN_SPAM_PILL_4 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [home-assistant.io,proxmox.com] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Ok. Here is the error message: referenced path 'Ubuntu 24.04 (64bit)-disk001.vmdk' is invalid (500) Hope this helps. Thanks Em qua., 20 de nov. de 2024 =C3=A0s 13:32, Gilberto Ferreira via pve-devel = < pve-devel@lists.proxmox.com> escreveu: > > > > ---------- Forwarded message ---------- > From: Gilberto Ferreira > To: Proxmox VE development discussion > Cc: Lukas Wagner , d.csapak@proxmox.com > Bcc: > Date: Wed, 20 Nov 2024 13:32:05 -0300 > Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement > ova/ovf import for file based storages > Hi there. > Sorry for the email, but I tested this import option with an Ubuntu ova > which has space in the vmdk name and I believe that could lead to errors. > I had downloaded from here: > > https://razaoinfo.dl.sourceforge.net/project/osboxes/v/vb/55-U-u/OVA-Vers= ions/24.04/Ubuntu-24.04-64bit-VB.ova > When I tried to import got error 500! > Unfortunately I didn't get the entire error message or any logs. > Is it some kind of error or bug? > > Nevertheless, I would like to say thanks for this amazing feature. > > Cheers > > > > > > > Em ter., 19 de nov. de 2024 =C3=A0s 05:49, Thomas Lamprecht < > t.lamprecht@proxmox.com> escreveu: > > > Am 19.11.24 um 09:15 schrieb Lukas Wagner: > > > On Mon Nov 18, 2024 at 2:53 PM CET, Dominik Csapak wrote: > > >>>> nothing special, I tested the feature using the Home Assistant .ov= a > > from > > >>>> [1]. Downloaded the OVA to my local storage, pressed "import", did > not > > >>>> change *any* settings apart from ticking "live import". > > >>>> The import works, but the VM is not started. Starting the VM > manually > > >>>> works fine, also the tasks log does not show anything of concern. > > >>>> In the browser network requests I saw that 'live-restore' is set t= o > > '1' > > >>>> in the import POST request. > > >>>> > > >>>> [1] https://www.home-assistant.io/installation/alternative/ > > >>> > > >>> > > >>> mhmm can reproduce with that ova image, maybe it has something to d= o > > with our > > >>> ovf import not detecting the main disk? > > >>> (at least here it does not detect any disk) > > >>> > > >>> > > >> > > >> ok two things here: > > >> > > >> * this ova is malformed it seems, it has a HostResource of > > '/disk/vmidsk1' when > > >> the spec says it should be of the form 'ovf:/disk/vmdisk1' which is > > what we look for > > >> (we could make that optional though?) > > >> > > >> * seemingly live-import does not start the vm if there was no disk, > but > > AFAICS > > >> this was pre-existing and not something my series introduced (but no= t > > sure either) > > >> > > > > > > Ah, thanks for the investigation. Maybe it'd be worth to check whethe= r > > > other hypervisors accept the malformed resource definition and then a= dd > > > support to PVE as well if this is the case. > > > > > > Btw. it should work now already, the GNS3 image that Filip linked to in > > his reply > > used the same format, so this seems to be relatively common. > > > > I used the GNS3 one yesterday as test case to integrate some detection > > quirks, I > > also had to accept whitespace in the OVA disk names (we normalize those > as > > standard > > PVE volume name through import anyway). > > > > I then also imported A HAOS OVA image, that works in general, but the > disk > > was not > > added as boot device, and the disk bus was LSI, I needed to change both > to > > make the > > disk available for OVMF. IIRC the OS type was detected "Others" on > import, > > I changed > > that, but seems not all defaults changed with it =E2=80=93 maybe one co= uld look > > into that? > > HAOS is a common usecase, I alone installed it twice this year, back th= en > > I had to > > use the qcow2 image and manually import that like a cave man though heh= e > > > > > > _______________________________________________ > > pve-devel mailing list > > pve-devel@lists.proxmox.com > > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > > > > ---------- Forwarded message ---------- > From: Gilberto Ferreira via pve-devel > To: Proxmox VE development discussion > Cc: Gilberto Ferreira , Lukas Wagner < > l.wagner@proxmox.com> > Bcc: > Date: Wed, 20 Nov 2024 13:32:05 -0300 > Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement > ova/ovf import for file based storages > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > --===============0689681968782094833== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============0689681968782094833==--