From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 8C43C1FF161
for <inbox@lore.proxmox.com>; Wed, 20 Nov 2024 17:32:46 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1EACA14384;
Wed, 20 Nov 2024 17:32:52 +0100 (CET)
References: <20241115151749.633407-1-d.csapak@proxmox.com>
<D5PBS0NDDO22.3ENLUV15D4DG4@proxmox.com>
<6efce1fc-0e03-4966-ac3a-ee433f2acc01@proxmox.com>
<D5PCHKPRRKZC.335GKK7ESX61O@proxmox.com>
<21c1cac9-3e70-4b37-9767-d5cc160c9ca9@proxmox.com>
<039ab04f-48e2-4285-91c3-ffe95ee372b9@proxmox.com>
<D5Q07WV14ROB.3BIJYETI77TBU@proxmox.com>
<1c8f245c-ac98-4633-9c10-69e6a7dd7b2a@proxmox.com>
In-Reply-To: <1c8f245c-ac98-4633-9c10-69e6a7dd7b2a@proxmox.com>
Date: Wed, 20 Nov 2024 13:32:05 -0300
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
MIME-Version: 1.0
Message-ID: <mailman.512.1732120371.391.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Gilberto Ferreira via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Gilberto Ferreira <gilberto.nunes32@gmail.com>,
Lukas Wagner <l.wagner@proxmox.com>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement
ova/ovf import for file based storages
Content-Type: multipart/mixed; boundary="===============7789072608683061129=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
--===============7789072608683061129==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <gilberto.nunes32@gmail.com>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 44A18C7ACD
for <pve-devel@lists.proxmox.com>; Wed, 20 Nov 2024 17:32:51 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 2505B14364
for <pve-devel@lists.proxmox.com>; Wed, 20 Nov 2024 17:32:51 +0100 (CET)
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c])
(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 20 Nov 2024 17:32:50 +0100 (CET)
Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-53da2140769so5091594e87.3
for <pve-devel@lists.proxmox.com>; Wed, 20 Nov 2024 08:32:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1732120363; x=1732725163; darn=lists.proxmox.com;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=x+kOKDttf/mvi+GuczHhl1M1ihBEcUhZHCB9goJgjCk=;
b=IRv81tYLyUghIUMkTg5MvWBf2ngwg5CGJbQLgzP680G0Z1eqLnGxNz6RNs/2+qtd8s
M5HTY/x0drWKqQm9jo85KBbA/3TmpzEREy3eKDTEBPQwa65Dd4gI0Z/3CPYrs7Hmav19
IBDuj1Mdcs1Jnxv2e2LZL3Paq5BRc4C+ObudfbrnQTQnZPpvTO8KaUywLqmWKMFF0f4R
Vhs11ukKN8llAs63l6pS3IGyBd6afV7rQVI//0ugf7vz8oFlPBIQVpZt9gXOGoneBjd5
Y+IfYi2QAU1/la68BLRHyvCXsM8dXH7y0VAyCqNSWfroc8um0y6pJOA7ZCFp4hRq1kpn
AWsg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1732120363; x=1732725163;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=x+kOKDttf/mvi+GuczHhl1M1ihBEcUhZHCB9goJgjCk=;
b=xF3K1PAAG7VIK2ByT8r0kaI+dN2A48WRn16lbswGs9Iq+UzmBHA/zud95MPiMb91Y7
n57a0umdJQxkCs5UjX8QQDEcuy3NCcCvPV9c+3LdJMnp9jScmvNyeTCh6Gx3moKfr5nw
HFZ0vetHy2aLvPDp0BerTTI9aSNTUCp4O0hRwJMrSlCb5r+mT4MT/qBtttdDaZOb21Dl
rZNtUoLEg97HkuCDMeczeAlHLy0Jk+8gTc3rgx7X0O6qllNAYVwgfORzrt9RQwDGH9ow
f96QBILPVDENCPHI7wZk0ar1c4iaJlG4EI8nsCkPS4efHvHyxKYlyuiF6HXC71c6LVaM
k4CA==
X-Gm-Message-State: AOJu0Yx6S1pThx9uCLVu0c8Iuar6Bv/+vuwTTnmbrIqCnC0XMra/JbsI
9XgNluShYYhOtrjaHp0Z4LDbsqi6odCzhExFEq6XZagmgyMqGU9GJAWZR1K3OgSbJxeSDKUqe7+
M+TwmUYq9TjsFpGRgIOR0qZoKolm6e3sn3n8=
X-Google-Smtp-Source: AGHT+IEoy5L7prQl4/OOie5pnsnqXuMy8Fm+wLNN1PIErdIIGFBOvXYC1v20t1mOM9ZNb8Lniwq21gBboi+yS5oF8hU=
X-Received: by 2002:ac2:4c26:0:b0:536:a275:9d61 with SMTP id
2adb3069b0e04-53dc1333a6dmr1430058e87.21.1732120362727; Wed, 20 Nov 2024
08:32:42 -0800 (PST)
MIME-Version: 1.0
References: <20241115151749.633407-1-d.csapak@proxmox.com> <D5PBS0NDDO22.3ENLUV15D4DG4@proxmox.com>
<6efce1fc-0e03-4966-ac3a-ee433f2acc01@proxmox.com> <D5PCHKPRRKZC.335GKK7ESX61O@proxmox.com>
<21c1cac9-3e70-4b37-9767-d5cc160c9ca9@proxmox.com> <039ab04f-48e2-4285-91c3-ffe95ee372b9@proxmox.com>
<D5Q07WV14ROB.3BIJYETI77TBU@proxmox.com> <1c8f245c-ac98-4633-9c10-69e6a7dd7b2a@proxmox.com>
In-Reply-To: <1c8f245c-ac98-4633-9c10-69e6a7dd7b2a@proxmox.com>
From: Gilberto Ferreira <gilberto.nunes32@gmail.com>
Date: Wed, 20 Nov 2024 13:32:05 -0300
Message-ID: <CAOKSTBvy5hemAM1+9rV8Y_Z1vZ_gCy5JtUJSxFmRTJVQDLbtNw@mail.gmail.com>
Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement
ova/ovf import for file based storages
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Lukas Wagner <l.wagner@proxmox.com>, d.csapak@proxmox.com
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.047 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain
DMARC_PASS -0.1 DMARC pass policy
FREEMAIL_ENVFROM_END_DIGIT 0.25 Envelope-from freemail username ends in digit
FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider
HTML_MESSAGE 0.001 HTML included in message
POISEN_SPAM_PILL_4 0.1 random spam to be learned in bayes
RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com,home-assistant.io]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Hi there.
Sorry for the email, but I tested this import option with an Ubuntu ova
which has space in the vmdk name and I believe that could lead to errors.
I had downloaded from here:
https://razaoinfo.dl.sourceforge.net/project/osboxes/v/vb/55-U-u/OVA-Versio=
ns/24.04/Ubuntu-24.04-64bit-VB.ova
When I tried to import got error 500!
Unfortunately I didn't get the entire error message or any logs.
Is it some kind of error or bug?
Nevertheless, I would like to say thanks for this amazing feature.
Cheers
Em ter., 19 de nov. de 2024 =C3=A0s 05:49, Thomas Lamprecht <
t.lamprecht@proxmox.com> escreveu:
> Am 19.11.24 um 09:15 schrieb Lukas Wagner:
> > On Mon Nov 18, 2024 at 2:53 PM CET, Dominik Csapak wrote:
> >>>> nothing special, I tested the feature using the Home Assistant .ova
> from
> >>>> [1]. Downloaded the OVA to my local storage, pressed "import", did n=
ot
> >>>> change *any* settings apart from ticking "live import".
> >>>> The import works, but the VM is not started. Starting the VM manuall=
y
> >>>> works fine, also the tasks log does not show anything of concern.
> >>>> In the browser network requests I saw that 'live-restore' is set to
> '1'
> >>>> in the import POST request.
> >>>>
> >>>> [1] https://www.home-assistant.io/installation/alternative/
> >>>
> >>>
> >>> mhmm can reproduce with that ova image, maybe it has something to do
> with our
> >>> ovf import not detecting the main disk?
> >>> (at least here it does not detect any disk)
> >>>
> >>>
> >>
> >> ok two things here:
> >>
> >> * this ova is malformed it seems, it has a HostResource of
> '/disk/vmidsk1' when
> >> the spec says it should be of the form 'ovf:/disk/vmdisk1' which is
> what we look for
> >> (we could make that optional though?)
> >>
> >> * seemingly live-import does not start the vm if there was no disk, bu=
t
> AFAICS
> >> this was pre-existing and not something my series introduced (but not
> sure either)
> >>
> >
> > Ah, thanks for the investigation. Maybe it'd be worth to check whether
> > other hypervisors accept the malformed resource definition and then add
> > support to PVE as well if this is the case.
>
>
> Btw. it should work now already, the GNS3 image that Filip linked to in
> his reply
> used the same format, so this seems to be relatively common.
>
> I used the GNS3 one yesterday as test case to integrate some detection
> quirks, I
> also had to accept whitespace in the OVA disk names (we normalize those a=
s
> standard
> PVE volume name through import anyway).
>
> I then also imported A HAOS OVA image, that works in general, but the dis=
k
> was not
> added as boot device, and the disk bus was LSI, I needed to change both t=
o
> make the
> disk available for OVMF. IIRC the OS type was detected "Others" on import=
,
> I changed
> that, but seems not all defaults changed with it =E2=80=93 maybe one coul=
d look
> into that?
> HAOS is a common usecase, I alone installed it twice this year, back then
> I had to
> use the qcow2 image and manually import that like a cave man though hehe
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
--===============7789072608683061129==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============7789072608683061129==--